Issue 10822002: Media Galleries API: hookup the AllGalleries permission and add tests.

Issue 10822002: Media Galleries API: hookup the AllGalleries permission and add tests. (Closed)

Created:
8 years, 5 months ago by vandebo (ex-Chrome)

Modified:
8 years, 5 months ago

Reviewers:
Matt Perry, Evan Stade

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Media Galleries API: hookup the AllGalleries permission and add tests. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148694

Patch Set 4 : Fix non-Linux compile #

Total comments: 2

Patch Set 5 : Address comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -72 lines)			Patch
M	chrome/browser/extensions/api/media_galleries/media_galleries_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc	View	1 2 3	1 chunk	+71 lines, -4 lines	0 comments	Download
M	chrome/browser/media_gallery/media_file_system_registry.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/media_gallery/media_file_system_registry.cc	View	1	5 chunks	+28 lines, -3 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/media_galleries/experimental/manifest.json	View		1 chunk	+3 lines, -5 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/media_galleries/experimental/test.js	View		1 chunk	+23 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/media_galleries/manifest.json	View		1 chunk	+0 lines, -12 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/media_galleries/no_access/manifest.json	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/media_galleries/no_access/test.js	View	1 2 3 4	1 chunk	+30 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/media_galleries/no_galleries/manifest.json	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/media_galleries/no_galleries/test.js	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/media_galleries/read_access/manifest.json	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/media_galleries/read_access/test.js	View	1 2 3 4	1 chunk	+30 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/media_galleries/test.js	View		1 chunk	+0 lines, -46 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10822002/9002

8 years, 5 months ago (2012-07-26 16:47:44 UTC) #4

commit-bot: I haz the power

Presubmit check for 10822002-9002 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 5 months ago (2012-07-26 16:48:02 UTC) #5

Matt Perry

lgtm https://chromiumcodereview.appspot.com/10822002/diff/9002/chrome/test/data/extensions/api_test/media_galleries/no_access/test.js File chrome/test/data/extensions/api_test/media_galleries/no_access/test.js (right): https://chromiumcodereview.appspot.com/10822002/diff/9002/chrome/test/data/extensions/api_test/media_galleries/no_access/test.js#newcode26 chrome/test/data/extensions/api_test/media_galleries/no_access/test.js:26: chrome.test.callbackPass(mediaFileSystemsDirectoryErrorCallback)); I think you can omit the argument ...

8 years, 5 months ago (2012-07-26 19:46:45 UTC) #7

vandebo (ex-Chrome)

https://chromiumcodereview.appspot.com/10822002/diff/9002/chrome/test/data/extensions/api_test/media_galleries/no_access/test.js File chrome/test/data/extensions/api_test/media_galleries/no_access/test.js (right): https://chromiumcodereview.appspot.com/10822002/diff/9002/chrome/test/data/extensions/api_test/media_galleries/no_access/test.js#newcode26 chrome/test/data/extensions/api_test/media_galleries/no_access/test.js:26: chrome.test.callbackPass(mediaFileSystemsDirectoryErrorCallback)); On 2012/07/26 19:46:47, Matt Perry wrote: > I ...

8 years, 5 months ago (2012-07-26 23:25:19 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10822002/15001

8 years, 5 months ago (2012-07-26 23:25:36 UTC) #9

Change committed as 148694

Expand Messages | Collapse Messages