Media Galleries API: hookup the AllGalleries permission and add tests.

chrome/browser/media_gallery/media_file_system_registry.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MediaFileSystemRegistry implementation.
 
 #include "chrome/browser/media_gallery/media_file_system_registry.h"
 
 #include <set>
 
+#include "base/file_path.h"
 #include "base/path_service.h"
+#include "base/system_monitor/system_monitor.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
+#include "chrome/common/extensions/extension.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "webkit/fileapi/isolated_context.h"
 
 namespace chrome {
 
 static base::LazyInstance<MediaFileSystemRegistry>::Leaky
     g_media_file_system_registry = LAZY_INSTANCE_INITIALIZER;
 
 using base::SystemMonitor;
 using content::BrowserThread;
 using content::RenderProcessHost;
 using fileapi::IsolatedContext;
 
+namespace {
+
+bool IsGalleryPermittedForExtension(const extensions::Extension& extension,
+                                    SystemMonitor::MediaDeviceType type,
+                                    const FilePath::StringType& location) {
+  if (extension.HasAPIPermission(
+        extensions::APIPermission::kMediaGalleriesAllGalleries)) {
+    return true;
+  }
+  // TODO(vandebo) Check with prefs for permission to this gallery.
+  return false;
+}
+
+}  // namespace
+
+
 /******************
  * Public methods
  ******************/
 
 // static
 MediaFileSystemRegistry* MediaFileSystemRegistry::GetInstance() {
   return g_media_file_system_registry.Pointer();
 }
 
 std::vector<MediaFileSystemRegistry::MediaFSIDAndPath>
 MediaFileSystemRegistry::GetMediaFileSystems(
-    const content::RenderProcessHost* rph) {
+    const content::RenderProcessHost* rph,
+    const extensions::Extension& extension) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   std::vector<MediaFSIDAndPath> results;
   std::pair<ChildIdToMediaFSMap::iterator, bool> ret =
       media_fs_map_.insert(std::make_pair(rph, MediaPathToFSIDMap()));
   ChildIdToMediaFSMap::iterator& child_it = ret.first;
   if (ret.second) {
     // Never seen a GetMediaFileSystems call from this RPH. Initialize its
     // file system mappings.
     RegisterForRPHGoneNotifications(rph);
     FilePath pictures_path;
-    if (PathService::Get(chrome::DIR_USER_PICTURES, &pictures_path)) {
+    // TODO(vandebo) file system galleries need a unique id as well.
+    if (PathService::Get(chrome::DIR_USER_PICTURES, &pictures_path) &&
+        IsGalleryPermittedForExtension(extension, SystemMonitor::TYPE_PATH,
+                                       pictures_path.value())) {
       std::string fsid = RegisterPathAsFileSystem(pictures_path);
       child_it->second.insert(std::make_pair(pictures_path, fsid));
     }
   }
 
   // TODO(thestig) Handle overlap between devices and media directories.
   SystemMonitor* monitor = SystemMonitor::Get();
   const std::vector<SystemMonitor::MediaDeviceInfo> media_devices =
       monitor->GetAttachedMediaDevices();
   for (size_t i = 0; i < media_devices.size(); ++i) {
-    if (media_devices[i].type == SystemMonitor::TYPE_PATH) {
+    if (media_devices[i].type == SystemMonitor::TYPE_PATH &&
+        IsGalleryPermittedForExtension(extension, media_devices[i].type,
+                                       media_devices[i].location)) {
       FilePath path(media_devices[i].location);
       device_id_map_.insert(std::make_pair(media_devices[i].unique_id, path));
       const std::string fsid = RegisterPathAsFileSystem(path);
       child_it->second.insert(std::make_pair(path, fsid));
     }
   }
 
   MediaPathToFSIDMap& child_map = child_it->second;
   for (MediaPathToFSIDMap::const_iterator it = child_map.begin();
        it != child_map.end();
@@ skipping 87 matching lines @@
     MediaPathToFSIDMap& child_map = child_it->second;
     MediaPathToFSIDMap::iterator media_path_it = child_map.find(path);
     if (media_path_it == child_map.end())
       continue;
     isolated_context->RevokeFileSystem(media_path_it->second);
     child_map.erase(media_path_it);
   }
 }
 
 }  // namespace chrome