Issue 10821100: Change NumberOfWaveOutBuffers() to return 3 for Windows >= Vista (instead of ==).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10821100: Change NumberOfWaveOutBuffers() to return 3 for Windows >= Vista (instead of ==). (Closed)

Created:
8 years, 4 months ago by viettrungluu

Modified:
8 years, 4 months ago

Reviewers:
cpu_(ooo_6.6-7.5), scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change NumberOfWaveOutBuffers() to return 3 for Windows >= Vista (instead of ==). BUG=136624 TEST=See bug (SB Audigy SE configured at 48 kHz (default) on Win7 + Flapper). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149119

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	media/audio/audio_util.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm http://codereview.chromium.org/10821100/diff/1/media/audio/audio_util.cc File media/audio/audio_util.cc (right): http://codereview.chromium.org/10821100/diff/1/media/audio/audio_util.cc#newcode550 media/audio/audio_util.cc:550: // Windows 7. Maybe it is fixed in ...

8 years, 4 months ago (2012-07-31 02:20:13 UTC) #2

scherkus (not reviewing)

8 years, 4 months ago (2012-07-31 02:21:35 UTC) #3

lgtm -- we'll test this out as well

https://chromiumcodereview.appspot.com/10821100/diff/1/media/audio/audio_util.cc
File media/audio/audio_util.cc (right):

https://chromiumcodereview.appspot.com/10821100/diff/1/media/audio/audio_util...
media/audio/audio_util.cc:550: // Windows 7. Maybe it is fixed in Vista Serice
Pack, but let's be cautious.
On 2012/07/31 02:20:13, cpu wrote:
> remove the "was fixed in windows 7"
+1

Expand Messages | Collapse Messages