Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: media/audio/audio_util.cc

Issue 10821100: Change NumberOfWaveOutBuffers() to return 3 for Windows >= Vista (instead of ==). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updated comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_util.cc
diff --git a/media/audio/audio_util.cc b/media/audio/audio_util.cc
index 0526616c426b46bf265df8a580ba9b9dcb69d25e..8dfaa2a452876c1d7ab3aaf488add5254a0f4b06 100644
--- a/media/audio/audio_util.cc
+++ b/media/audio/audio_util.cc
@@ -546,10 +546,10 @@ int NumberOfWaveOutBuffers() {
// 2 otherwise.
// Entire Windows audio stack was rewritten for Windows Vista, and wave out
// API is simulated on top of new API, so there is noticeable performance
- // degradation compared to Windows XP. Part of regression was fixed in
- // Windows 7. Maybe it is fixed in Vista Serice Pack, but let's be cautious.
+ // degradation compared to Windows XP. Part of regression was apparently fixed
+ // in Windows 7, but problems remain at least with some configurations.
if ((base::SysInfo::NumberOfProcessors() < 2) ||
- (base::win::GetVersion() == base::win::VERSION_VISTA)) {
+ (base::win::GetVersion() >= base::win::VERSION_VISTA)) {
return 3;
}
return 2;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698