Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10821097: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 4 months ago by rpetterson
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 TEST=unittests, manual TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149547

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -35 lines) Patch
M chrome/browser/bookmarks/bookmark_context_menu_controller.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_editor.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_expanded_state_tracker_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_extension_api.cc View 1 7 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_index_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_apitest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data_unittest.cc View 1 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rpetterson
8 years, 4 months ago (2012-07-30 23:41:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10821097/4005
8 years, 4 months ago (2012-08-01 23:22:05 UTC) #2
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 00:53:48 UTC) #3 
Change committed as 149547

Powered by Google App Engine
This is Rietveld 408576698