Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3912)

Unified Diff: chrome/browser/bookmarks/bookmark_manager_extension_api.cc

Issue 10821097: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_manager_extension_api.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_manager_extension_api.cc (revision 149452)
+++ chrome/browser/bookmarks/bookmark_manager_extension_api.cc (working copy)
@@ -12,6 +12,7 @@
#include "chrome/browser/bookmarks/bookmark_extension_api_constants.h"
#include "chrome/browser/bookmarks/bookmark_extension_helpers.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/bookmark_node_data.h"
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/extensions/event_router.h"
@@ -223,7 +224,7 @@
}
bool ClipboardBookmarkManagerFunction::CopyOrCut(bool cut) {
- BookmarkModel* model = profile()->GetBookmarkModel();
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
std::vector<const BookmarkNode*> nodes;
EXTENSION_FUNCTION_VALIDATE(GetNodesFromArguments(model, args_.get(),
0, &nodes));
@@ -244,7 +245,7 @@
bool PasteBookmarkManagerFunction::RunImpl() {
if (!EditBookmarksEnabled())
return false;
- BookmarkModel* model = profile()->GetBookmarkModel();
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* parent_node = GetNodeFromArguments(model, args_.get());
if (!parent_node) {
error_ = keys::kNoParentError;
@@ -273,7 +274,7 @@
bool CanPasteBookmarkManagerFunction::RunImpl() {
if (!EditBookmarksEnabled())
return false;
- BookmarkModel* model = profile()->GetBookmarkModel();
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* parent_node = GetNodeFromArguments(model, args_.get());
if (!parent_node) {
error_ = keys::kNoParentError;
@@ -287,7 +288,7 @@
bool SortChildrenBookmarkManagerFunction::RunImpl() {
if (!EditBookmarksEnabled())
return false;
- BookmarkModel* model = profile()->GetBookmarkModel();
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* parent_node = GetNodeFromArguments(model, args_.get());
if (!parent_node) {
error_ = keys::kNoParentError;
@@ -383,7 +384,7 @@
bool StartDragBookmarkManagerFunction::RunImpl() {
if (!EditBookmarksEnabled())
return false;
- BookmarkModel* model = profile()->GetBookmarkModel();
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
std::vector<const BookmarkNode*> nodes;
EXTENSION_FUNCTION_VALIDATE(
GetNodesFromArguments(model, args_.get(), 0, &nodes));
@@ -408,7 +409,7 @@
if (!EditBookmarksEnabled())
return false;
- BookmarkModel* model = profile()->GetBookmarkModel();
+ BookmarkModel* model =BookmarkModelFactory::GetForProfile(profile());
int64 id;
std::string id_string;
@@ -462,7 +463,7 @@
}
bool GetSubtreeBookmarkManagerFunction::RunImpl() {
- BookmarkModel* model = profile()->GetBookmarkModel();
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
const BookmarkNode* node;
int64 id;
std::string id_string;
« no previous file with comments | « chrome/browser/bookmarks/bookmark_index_unittest.cc ('k') | chrome/browser/bookmarks/bookmark_manager_extension_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698