Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 10820053: Fix kStoreBufferBlockProcessRuntimeEntry call sequence. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: remove meaningless assertion Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc
index b55c4e20e1d3e1f205fb6ca4e3a18ba1e2d60020..6f4d4c4b57e70a3d2f885c4150df7a9c563f60db 100644
--- a/runtime/vm/stub_code_x64.cc
+++ b/runtime/vm/stub_code_x64.cc
@@ -102,15 +102,10 @@ END_LEAF_RUNTIME_ENTRY
// RDI : stop message (const char*).
// Must preserve all registers.
void StubCode::GeneratePrintStopMessageStub(Assembler* assembler) {
- __ enter(Immediate(0));
- __ PreserveCallerSavedRegisters();
-
+ __ EnterCallRuntimeFrame(0);
// Call the runtime leaf function. RDI already contains the parameter.
- __ ReserveAlignedFrameSpace(0);
__ CallRuntime(kPrintStopMessageRuntimeEntry);
-
- __ RestoreCallerSavedRegisters();
- __ leave();
+ __ LeaveCallRuntimeFrame();
__ ret();
}
@@ -1087,14 +1082,10 @@ void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
// Handle overflow: Call the runtime leaf function.
__ Bind(&L);
// Setup frame, push callee-saved registers.
- __ enter(Immediate(0));
- __ PreserveCallerSavedRegisters();
- __ ReserveAlignedFrameSpace(0);
+ __ EnterCallRuntimeFrame(0);
__ movq(RDI, FieldAddress(CTX, Context::isolate_offset()));
__ CallRuntime(kStoreBufferBlockProcessRuntimeEntry);
- // Restore callee-saved registers, tear down frame.
- __ RestoreCallerSavedRegisters();
- __ leave();
+ __ LeaveCallRuntimeFrame();
__ ret();
}
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698