Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 10820053: Fix kStoreBufferBlockProcessRuntimeEntry call sequence. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: remove meaningless assertion Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index b3ca12622cec70b8d2f3d3fbfea84eaea285d6d6..5635a31448c9ca74ff4f5f611b1b6e6cc04cffb4 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -100,16 +100,10 @@ END_LEAF_RUNTIME_ENTRY
// EAX : stop message (const char*).
// Must preserve all registers, except EAX.
void StubCode::GeneratePrintStopMessageStub(Assembler* assembler) {
- __ enter(Immediate(0));
- __ PreserveCallerSavedRegisters();
-
- // Call the runtime leaf function.
- __ ReserveAlignedFrameSpace(1 * kWordSize);
+ __ EnterCallRuntimeFrame(1 * kWordSize);
__ movl(Address(ESP, 0), EAX);
__ CallRuntime(kPrintStopMessageRuntimeEntry);
-
- __ RestoreCallerSavedRegisters();
- __ leave();
+ __ LeaveCallRuntimeFrame();
__ ret();
}
@@ -1109,15 +1103,13 @@ void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
// Handle overflow: Call the runtime leaf function.
__ Bind(&L);
// Setup frame, push callee-saved registers.
- __ enter(Immediate(0));
- __ PreserveCallerSavedRegisters();
+
+ __ EnterCallRuntimeFrame(1 * kWordSize);
__ movl(EAX, FieldAddress(CTX, Context::isolate_offset()));
- __ ReserveAlignedFrameSpace(1 * kWordSize);
__ movl(Address(ESP, 0), EAX); // Push the isolate as the only argument.
__ CallRuntime(kStoreBufferBlockProcessRuntimeEntry);
// Restore callee-saved registers, tear down frame.
- __ RestoreCallerSavedRegisters();
- __ leave();
+ __ LeaveCallRuntimeFrame();
__ ret();
}
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698