Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 10818042: Add construction checksum to safe-browsing's BloomFilter. (Closed)

Created:
8 years, 5 months ago by Scott Hess - ex-Googler
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add construction checksum to safe-browsing's BloomFilter. Intending to use this to track down suspected memory corruption. BUG=71832 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M chrome/browser/safe_browsing/bloom_filter.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/bloom_filter.cc View 5 chunks +32 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/bloom_filter_unittest.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
There's a bigger CL coming, but I broke this out separately to focus arguments.
8 years, 5 months ago (2012-07-24 21:43:19 UTC) #1
ramant (doing other things)
lgtm
8 years, 5 months ago (2012-07-24 23:34:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10818042/1
8 years, 5 months ago (2012-07-25 05:16:48 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 07:07:08 UTC) #4
Change committed as 148299

Powered by Google App Engine
This is Rietveld 408576698