Issue 10818042: Add construction checksum to safe-browsing's BloomFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10818042: Add construction checksum to safe-browsing's BloomFilter. (Closed)

Created:
8 years, 5 months ago by Scott Hess - ex-Googler

Modified:
8 years, 5 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Add construction checksum to safe-browsing's BloomFilter. Intending to use this to track down suspected memory corruption. BUG=71832 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148299

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -1 line)			Patch
M	chrome/browser/safe_browsing/bloom_filter.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/bloom_filter.cc	View	5 chunks	+32 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/bloom_filter_unittest.cc	View	3 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Scott Hess - ex-Googler

There's a bigger CL coming, but I broke this out separately to focus arguments.

8 years, 5 months ago (2012-07-24 21:43:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10818042/1

8 years, 5 months ago (2012-07-25 05:16:48 UTC) #3

Change committed as 148299