Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6942)

Unified Diff: chrome/browser/safe_browsing/bloom_filter_unittest.cc

Issue 10818042: Add construction checksum to safe-browsing's BloomFilter. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/bloom_filter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/bloom_filter_unittest.cc
diff --git a/chrome/browser/safe_browsing/bloom_filter_unittest.cc b/chrome/browser/safe_browsing/bloom_filter_unittest.cc
index f7f226037441996eebd0b4768c6919a1ee48a259..08507c797d01d6169c15c0052c7ec3299d880fdf 100644
--- a/chrome/browser/safe_browsing/bloom_filter_unittest.cc
+++ b/chrome/browser/safe_browsing/bloom_filter_unittest.cc
@@ -41,12 +41,14 @@ TEST(SafeBrowsingBloomFilter, BloomFilterUse) {
values.insert(value);
filter->Insert(value);
}
+ EXPECT_TRUE(filter->CheckChecksum());
// Check serialization works.
char* data_copy = new char[filter->size()];
memcpy(data_copy, filter->data(), filter->size());
scoped_refptr<BloomFilter> filter_copy(
new BloomFilter(data_copy, filter->size(), filter->hash_keys_));
+ EXPECT_TRUE(filter_copy->CheckChecksum());
// Check no false negatives by ensuring that every time we inserted exists.
for (Values::const_iterator i = values.begin(); i != values.end(); ++i)
@@ -88,6 +90,7 @@ TEST(SafeBrowsingBloomFilter, BloomFilterFile) {
for (int i = 0; i < kTestEntries; ++i)
filter_write->Insert(GenHash());
+ EXPECT_TRUE(filter_write->CheckChecksum());
// Remove any left over test filters and serialize.
ScopedTempDir temp_dir;
@@ -99,6 +102,7 @@ TEST(SafeBrowsingBloomFilter, BloomFilterFile) {
BloomFilter* filter = BloomFilter::LoadFile(filter_path);
ASSERT_TRUE(filter != NULL);
scoped_refptr<BloomFilter> filter_read(filter);
+ EXPECT_TRUE(filter_read->CheckChecksum());
// Check data consistency.
EXPECT_EQ(filter_write->hash_keys_.size(), filter_read->hash_keys_.size());
« no previous file with comments | « chrome/browser/safe_browsing/bloom_filter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698