Allow floating point rectangles to be sent via IPC.

Allow floating point rectangles to be sent via IPC.

These are required by the Android find-in-page implementation. Further patches
will introduce automatic conversion from WebKit::WebFloatRect to gfx::RectF.


BUG=136762
TEST=new case added to base_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147974

[Leandro Graciá Gil, 2012-07-23 18:30:48]

sky: will need an owner for the ui gyp changes. Could you please take a look?
brett: please check the changes to Pickle in base and to common_param_traits.

For now this is only needed for the Android platform. However since rects are
quite common objects I'm not sure if it's worth introducing lots of OS_ANDROID
guards in a code as common as this (e.g. Pickle and its unit test). I'm open to
suggestions.

Thanks!

[sky, 2012-07-23 19:05:34]

LGTM

[brettw, 2012-07-23 19:06:21]

https://chromiumcodereview.appspot.com/10818011/diff/1/content/public/common/...
File content/public/common/common_param_traits.cc (right):

https://chromiumcodereview.appspot.com/10818011/diff/1/content/public/common/...
content/public/common/common_param_traits.cc:427: m->WriteFloat(p.x());
I'd avoid adding anything to pickle and instead use
IPC::ParamTraits<float>::Read/Write. I'm not sure why this is separate from
pickle, but I think the param traits is more correct anyway.

[Leandro Graciá Gil, 2012-07-23 20:45:35]

https://chromiumcodereview.appspot.com/10818011/diff/1/content/public/common/...
File content/public/common/common_param_traits.cc (right):

https://chromiumcodereview.appspot.com/10818011/diff/1/content/public/common/...
content/public/common/common_param_traits.cc:427: m->WriteFloat(p.x());
SGTM. Fixed.

On 2012/07/23 19:06:21, brettw wrote:
> I'd avoid adding anything to pickle and instead use
> IPC::ParamTraits<float>::Read/Write. I'm not sure why this is separate from
> pickle, but I think the param traits is more correct anyway.

[brettw, 2012-07-23 21:05:36]

lgtm

[Leandro Graciá Gil, 2012-07-23 21:12:58]

Thanks for the review.

[commit-bot: I haz the power, 2012-07-23 21:13:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/10818011/8001

[commit-bot: I haz the power, 2012-07-23 22:39:43]

Change committed as 147974