Allow floating point rectangles to be sent via IPC.

content/public/common/common_param_traits.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/common_param_traits.h"
 
 #include "content/public/common/content_constants.h"
 #include "content/public/common/referrer.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/upload_data.h"
 #include "net/http/http_response_headers.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/range/range.h"
 #include "ui/gfx/rect.h"
+#include "ui/gfx/rect_f.h"
 
 namespace {
 
 struct SkBitmap_Data {
   // The configuration for the bitmap (bits per pixel, etc).
   SkBitmap::Config fConfig;
 
   // The width of the bitmap in pixels.
   uint32 fWidth;
 
@@ skipping 390 matching lines @@
   r->set_width(w);
   r->set_height(h);
   return true;
 }
 
 void ParamTraits<gfx::Rect>::Log(const gfx::Rect& p, std::string* l) {
   l->append(base::StringPrintf("(%d, %d, %d, %d)", p.x(), p.y(),
                                p.width(), p.height()));
 }
 
+void ParamTraits<gfx::RectF>::Write(Message* m, const gfx::RectF& p) {
+  m->WriteFloat(p.x());

[brettw, 2012/07/23 19:06:21]

I'd avoid adding anything to pickle and instead use
IPC::ParamTraits<float>::Read/Write. I'm not sure why this is separate from
pickle, but I think the param traits is more correct anyway.

[Leandro Graciá Gil, 2012/07/23 20:45:35]

SGTM. Fixed.

On 2012/07/23 19:06:21, brettw wrote:

+  m->WriteFloat(p.y());
+  m->WriteFloat(p.width());
+  m->WriteFloat(p.height());
+}
+
+bool ParamTraits<gfx::RectF>::Read(const Message* m,
+                                   PickleIterator* iter,
+                                   gfx::RectF* r) {
+  float x, y, w, h;
+  if (!m->ReadFloat(iter, &x) ||
+      !m->ReadFloat(iter, &y) ||
+      !m->ReadFloat(iter, &w) ||
+      !m->ReadFloat(iter, &h))
+    return false;
+  r->set_x(x);
+  r->set_y(y);
+  r->set_width(w);
+  r->set_height(h);
+  return true;
+}
+
+void ParamTraits<gfx::RectF>::Log(const gfx::RectF& p, std::string* l) {
+  l->append(base::StringPrintf("(%f, %f, %f, %f)", p.x(), p.y(),
+                               p.width(), p.height()));
+}
+
 void ParamTraits<ui::Range>::Write(Message* m, const ui::Range& r) {
   m->WriteUInt64(r.start());
   m->WriteUInt64(r.end());
 }
 
 bool ParamTraits<ui::Range>::Read(const Message* m,
                                   PickleIterator* iter,
                                   ui::Range* r) {
   uint64 start, end;
   if (!m->ReadUInt64(iter, &start) || !m->ReadUInt64(iter, &end))
@@ skipping 63 matching lines @@
 #undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
 #include "content/public/common/common_param_traits_macros.h"
 }  // namespace IPC
 
 // Generate param traits log methods.
 #include "ipc/param_traits_log_macros.h"
 namespace IPC {
 #undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
 #include "content/public/common/common_param_traits_macros.h"
 }  // namespace IPC