Issue 10817009: Revert 147867 - Move the HungRendererDialogView and HungPagesTableModel classes into a header file …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10817009: Revert 147867 - Move the HungRendererDialogView and HungPagesTableModel classes into a header file … (Closed)

Created:
8 years, 5 months ago by acolwell GONE FROM CHROMIUM

Modified:
8 years, 5 months ago

Reviewers:
ananta

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 147867 - Move the HungRendererDialogView and HungPagesTableModel classes into a header file hung_renderer_view.h. Add a windows specific override of the HungRendererDialogView class. This is in preparation for displaying the hung renderer dialog using the native metro dialog UI in Windows 8 metro. Reverted because it caused a ChromeOS compile error. BUG=125672 R=sky Review URL: https://chromiumcodereview.appspot.com/10790109 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147872

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -255 lines)			Patch
D	chrome/browser/ui/views/hung_renderer_view.h	View	1 chunk	+0 lines, -170 lines	0 comments	Download
M	chrome/browser/ui/views/hung_renderer_view.cc	View	10 chunks	+172 lines, -41 lines	0 comments	Download
D	chrome/browser/ui/views/hung_renderer_view_win.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	chrome/browser/ui/views/hung_renderer_view_win.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)