Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10790109: Move the HungRendererDialogView and HungPagesTableModel classes into a header file hung_renderer_vi… (Closed)

Created:
8 years, 5 months ago by ananta
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Move the HungRendererDialogView and HungPagesTableModel classes into a header file hung_renderer_view.h. Add a windows specific override of the HungRendererDialogView class. This is in preparation for displaying the hung renderer dialog using the native metro dialog UI in Windows 8 metro. BUG=125672 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147867

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -623 lines) Patch
A + chrome/browser/ui/views/hung_renderer_view.h View 1 2 3 4 chunks +23 lines, -451 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 2 10 chunks +41 lines, -172 lines 0 comments Download
A chrome/browser/ui/views/hung_renderer_view_win.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/hung_renderer_view_win.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
8 years, 5 months ago (2012-07-20 22:41:15 UTC) #1
sky
https://chromiumcodereview.appspot.com/10790109/diff/11001/chrome/browser/ui/views/hung_renderer_view.h File chrome/browser/ui/views/hung_renderer_view.h (right): https://chromiumcodereview.appspot.com/10790109/diff/11001/chrome/browser/ui/views/hung_renderer_view.h#newcode21 chrome/browser/ui/views/hung_renderer_view.h:21: class HungPagesTableModel : public views::GroupTableModel { Can you svn ...
8 years, 5 months ago (2012-07-23 15:31:14 UTC) #2
sky
8 years, 5 months ago (2012-07-23 17:00:20 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698