Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 10816007: Refactor incremental marking to use static visitor. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger
Modified:
8 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Refactor incremental marking to use static visitor. This is a refactoring only change that switches incremental marking to use a static object visitor. It also shares the common code between the non-incremental and the incremental marker. Sharing that would require semantical changes will be done later. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12193

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Toon Verwaest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -289 lines) Patch
M src/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/incremental-marking.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/incremental-marking.cc View 1 10 chunks +79 lines, -83 lines 0 comments Download
M src/mark-compact.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 1 21 chunks +46 lines, -187 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/objects-visiting.h View 2 chunks +66 lines, -2 lines 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +134 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 5 months ago (2012-07-20 16:33:41 UTC) #1
Toon Verwaest
Lgtm with comment. https://chromiumcodereview.appspot.com/10816007/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): https://chromiumcodereview.appspot.com/10816007/diff/1/src/incremental-marking.cc#newcode882 src/incremental-marking.cc:882: JSFunction::kNonWeakFieldsEndOffset)); Is this the same as ...
8 years, 5 months ago (2012-07-23 13:10:21 UTC) #2
Michael Starzinger
8 years, 5 months ago (2012-07-25 08:21:32 UTC) #3
Addressed comments.

https://chromiumcodereview.appspot.com/10816007/diff/1/src/incremental-markin...
File src/incremental-marking.cc (right):

https://chromiumcodereview.appspot.com/10816007/diff/1/src/incremental-markin...
src/incremental-marking.cc:882: JSFunction::kNonWeakFieldsEndOffset));
On 2012/07/23 13:10:21, Toon Verwaest wrote:
> Is this the same as IncrementalMarkingMarkingVisitor::VisitJSFunction?

Done. Yes, it's should be the same. Changed so that the static visitor is used
here as well.

Powered by Google App Engine
This is Rietveld 408576698