Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/mark-compact.h

Issue 10816007: Refactor incremental marking to use static visitor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Toon Verwaest. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/incremental-marking.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 // Phase 1: Marking live objects. 630 // Phase 1: Marking live objects.
631 // 631 //
632 // Before: The heap has been prepared for garbage collection by 632 // Before: The heap has been prepared for garbage collection by
633 // MarkCompactCollector::Prepare() and is otherwise in its 633 // MarkCompactCollector::Prepare() and is otherwise in its
634 // normal state. 634 // normal state.
635 // 635 //
636 // After: Live objects are marked and non-live objects are unmarked. 636 // After: Live objects are marked and non-live objects are unmarked.
637 637
638 friend class RootMarkingVisitor; 638 friend class RootMarkingVisitor;
639 friend class MarkingVisitor; 639 friend class MarkingVisitor;
640 friend class StaticMarkingVisitor; 640 friend class MarkCompactMarkingVisitor;
641 friend class CodeMarkingVisitor; 641 friend class CodeMarkingVisitor;
642 friend class SharedFunctionInfoMarkingVisitor; 642 friend class SharedFunctionInfoMarkingVisitor;
643 friend class Marker<IncrementalMarking>; 643 friend class Marker<IncrementalMarking>;
644 friend class Marker<MarkCompactCollector>; 644 friend class Marker<MarkCompactCollector>;
645 645
646 // Mark non-optimize code for functions inlined into the given optimized 646 // Mark non-optimize code for functions inlined into the given optimized
647 // code. This will prevent it from being flushed. 647 // code. This will prevent it from being flushed.
648 void MarkInlinedFunctionsCode(Code* code); 648 void MarkInlinedFunctionsCode(Code* code);
649 649
650 // Mark code objects that are active on the stack to prevent them 650 // Mark code objects that are active on the stack to prevent them
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 787
788 friend class Heap; 788 friend class Heap;
789 }; 789 };
790 790
791 791
792 const char* AllocationSpaceName(AllocationSpace space); 792 const char* AllocationSpaceName(AllocationSpace space);
793 793
794 } } // namespace v8::internal 794 } } // namespace v8::internal
795 795
796 #endif // V8_MARK_COMPACT_H_ 796 #endif // V8_MARK_COMPACT_H_
OLDNEW
« no previous file with comments | « src/incremental-marking.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698