Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/ui/panels/panel_browser_frame_view.cc

Issue 10816004: Fixes missing 5 pixel inset for theme background in Ash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/panel_browser_frame_view.h" 5 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/themes/theme_service.h" 10 #include "chrome/browser/themes/theme_service.h"
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 return gfx::Rect(); 327 return gfx::Rect();
328 } 328 }
329 329
330 BrowserNonClientFrameView::TabStripInsets 330 BrowserNonClientFrameView::TabStripInsets
331 PanelBrowserFrameView::GetTabStripInsets( 331 PanelBrowserFrameView::GetTabStripInsets(
332 bool restored) const { 332 bool restored) const {
333 // This is not needed since we do not show tab strip for the panel. 333 // This is not needed since we do not show tab strip for the panel.
334 return TabStripInsets(); 334 return TabStripInsets();
335 } 335 }
336 336
337 int PanelBrowserFrameView::GetThemeBackgroundXInset() const {
338 return 0;
339 }
340
337 void PanelBrowserFrameView::UpdateThrobber(bool running) { 341 void PanelBrowserFrameView::UpdateThrobber(bool running) {
338 // Tells the title icon to update the throbber when we need to show the 342 // Tells the title icon to update the throbber when we need to show the
339 // animation to indicate we're still loading. 343 // animation to indicate we're still loading.
340 title_icon_->Update(); 344 title_icon_->Update();
341 } 345 }
342 346
343 gfx::Rect PanelBrowserFrameView::GetBoundsForClientView() const { 347 gfx::Rect PanelBrowserFrameView::GetBoundsForClientView() const {
344 return client_view_bounds_; 348 return client_view_bounds_;
345 } 349 }
346 350
(...skipping 452 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 } 803 }
800 804
801 bool PanelBrowserFrameView::CanResize() const { 805 bool PanelBrowserFrameView::CanResize() const {
802 return panel_browser_view_->panel()->CanResizeByMouse() != 806 return panel_browser_view_->panel()->CanResizeByMouse() !=
803 panel::NOT_RESIZABLE; 807 panel::NOT_RESIZABLE;
804 } 808 }
805 809
806 bool PanelBrowserFrameView::IsShowingTitlebarOnly() const { 810 bool PanelBrowserFrameView::IsShowingTitlebarOnly() const {
807 return height() <= panel::kTitlebarHeight; 811 return height() <= panel::kTitlebarHeight;
808 } 812 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_frame_view.h ('k') | chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698