mac: Let panels get its resize cursors from WebKit.

mac: Let panels get its resize cursors from WebKit.

This way, they pick up native cursors on Lion, and they no longer
implicitly depend on resources added to the bundle by WebCore.gyp.

Depends on https://chromiumcodereview.appspot.com/10815077/

BUG=137588
TEST=none
TBR=dimich (who lg'd with his @google instead of his OWNING @chromium)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148187

[Nico, 2012-07-24 18:44:28]

https://chromiumcodereview.appspot.com/10815077/diff/2001/chrome/browser/ui/p...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

https://chromiumcodereview.appspot.com/10815077/diff/2001/chrome/browser/ui/p...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:143:
[LoadWebKitCursor(WebKit::WebCursorInfo::TypeNorthSouthResize) retain]);
Note that native Lion windows use TypeNorthResize at the top edge,
TypeSouthResize at the bottom edge, etc. Maybe you want to fix this.

[Avi (use Gerrit), 2012-07-24 18:49:25]

https://chromiumcodereview.appspot.com/10815077/diff/2001/chrome/browser/ui/p...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

https://chromiumcodereview.appspot.com/10815077/diff/2001/chrome/browser/ui/p...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:131: static NSCursor*
LoadWebKitCursor(WebKit::WebCursorInfo::Type type) {
namespace { ... } ?

[Nico, 2012-07-24 18:52:08]

https://chromiumcodereview.appspot.com/10815077/diff/2001/chrome/browser/ui/p...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

https://chromiumcodereview.appspot.com/10815077/diff/2001/chrome/browser/ui/p...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:131: static NSCursor*
LoadWebKitCursor(WebKit::WebCursorInfo::Type type) {
On 2012/07/24 18:49:26, Avi wrote:
> namespace { ... } ?

Meh, done.

[Avi (use Gerrit), 2012-07-24 18:54:14]

This is exactly the change I wanted to make when I ran across this code a few
days ago. LGTM

[dimich, 2012-07-24 18:59:40]

lgtm as well.

[commit-bot: I haz the power, 2012-07-24 19:02:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10815077/7003

[commit-bot: I haz the power, 2012-07-24 19:02:14]

Presubmit check for 10815077-7003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/panels

[commit-bot: I haz the power, 2012-07-24 19:12:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10815077/7003

[commit-bot: I haz the power, 2012-07-24 20:39:17]

Change committed as 148187