Support copying a partial rectangle region from the compositing surface on Aura and GTK.

Support copying a partial rectangle region from the compositing surface on Aura and GTK.

BUG=118571
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148520

[mazda, 2012-07-24 21:26:49]

Hi Antoine,

Could you review this change?

Thanks,

[piman, 2012-07-26 00:04:51]

http://codereview.chromium.org/10815070/diff/8002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10815070/diff/8002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:825:
skia::PlatformCanvas* output) {
For mac and windows, where subrects are not supported, we should have a
NOTIMPLEMENTED() if !src_subrect.IsEmpty().

http://codereview.chromium.org/10815070/diff/8002/content/common/gpu/client/g...
File content/common/gpu/client/gl_helper.cc (right):

http://codereview.chromium.org/10815070/diff/8002/content/common/gpu/client/g...
content/common/gpu/client/gl_helper.cc:371: "                          
src_subrect.xy + v_texcoord * src_subrect.zw);"
It would be better to do the UV transformation in the vertex shader.
If you do it in the fragment shader, you pay for it at each pixel, whereas if
you do it in the vertex shader, then you only pay it for each vertex (i.e. 4
times total).

[mazda, 2012-07-26 02:20:03]

Thank you for the review. Please have another look.

http://codereview.chromium.org/10815070/diff/8002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10815070/diff/8002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:825:
skia::PlatformCanvas* output) {
On 2012/07/26 00:04:51, piman wrote:
> For mac and windows, where subrects are not supported, we should have a
> NOTIMPLEMENTED() if !src_subrect.IsEmpty().

Done.

http://codereview.chromium.org/10815070/diff/8002/content/common/gpu/client/g...
File content/common/gpu/client/gl_helper.cc (right):

http://codereview.chromium.org/10815070/diff/8002/content/common/gpu/client/g...
content/common/gpu/client/gl_helper.cc:371: "                          
src_subrect.xy + v_texcoord * src_subrect.zw);"
On 2012/07/26 00:04:51, piman wrote:
> It would be better to do the UV transformation in the vertex shader.
> If you do it in the fragment shader, you pay for it at each pixel, whereas if
> you do it in the vertex shader, then you only pay it for each vertex (i.e. 4
> times total).

Oh, that's right. Fixed.

[piman, 2012-07-26 02:46:17]

lgtm

[mazda, 2012-07-26 03:01:48]

Thanks!

+jam, could you do an OWNERS review for content?

[jam, 2012-07-26 04:10:52]

lgtm

[commit-bot: I haz the power, 2012-07-26 04:18:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10815070/17002

[commit-bot: I haz the power, 2012-07-26 05:44:07]

Change committed as 148520