Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 10815070: Support copying a partial rectangle region from the compositing surface on Aura and GTK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index 26561aedaf911294ba40b45db6252b493208ce28..f546d4e1d630f91be8a9c76389a918e710686c21 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -817,19 +817,27 @@ BackingStore* RenderWidgetHostViewMac::AllocBackingStore(
}
void RenderWidgetHostViewMac::CopyFromCompositingSurface(
- const gfx::Size& size,
+ const gfx::Rect& src_subrect,
+ const gfx::Size& dst_size,
const base::Callback<void(bool)>& callback,
skia::PlatformCanvas* output) {
base::ScopedClosureRunner scoped_callback_runner(base::Bind(callback, false));
+ // TODO(mazda): Support copying a partial rectangle from the compositing
+ // surface with |src_subrect| (http://crbug.com/118571).
+ if (!src_subrect.IsEmpty()) {
+ NOTIMPLEMENTED();
+ return;
+ }
+
if (!compositing_iosurface_.get() ||
!compositing_iosurface_->HasIOSurface())
return;
- if (!output->initialize(size.width(), size.height(), true))
+ if (!output->initialize(dst_size.width(), dst_size.height(), true))
return;
const bool result = compositing_iosurface_->CopyTo(
- size, output->getTopDevice()->accessBitmap(true).getPixels());
+ dst_size, output->getTopDevice()->accessBitmap(true).getPixels());
scoped_callback_runner.Release();
callback.Run(result);
}

Powered by Google App Engine
This is Rietveld 408576698