Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 10812002: Bug fixes for getTranslatedShader (Closed)

Created:
8 years, 5 months ago by dmurph
Modified:
8 years, 5 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Bug fixes for getTranslatedShader Fixed the following bugs: * Getting the length of translated shader source failed on pending compilation * Getting the translated shader source failed on pending compilation * Getting the translated shader source after a new source is set Small refactoring: * Put an enum in ShaderInfo for storing the compilation state BUG=137758 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147997

Patch Set 1 #

Total comments: 4

Patch Set 2 : merged #

Patch Set 3 : last fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 4 chunks +23 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 1 5 chunks +14 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmurph
8 years, 5 months ago (2012-07-19 17:41:21 UTC) #1
dmurph
merged patch
8 years, 5 months ago (2012-07-23 21:15:00 UTC) #2
greggman
lgtm http://codereview.chromium.org/10812002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/10812002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode5141 gpu/command_buffer/service/gles2_cmd_decoder.cc:5141: // We know there will be know errors, ...
8 years, 5 months ago (2012-07-23 22:13:03 UTC) #3
dmurph
http://codereview.chromium.org/10812002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/10812002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode5141 gpu/command_buffer/service/gles2_cmd_decoder.cc:5141: // We know there will be know errors, because ...
8 years, 5 months ago (2012-07-23 22:18:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmurph@chromium.org/10812002/5005
8 years, 5 months ago (2012-07-23 22:19:08 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 23:48:43 UTC) #6
Change committed as 147997

Powered by Google App Engine
This is Rietveld 408576698