lib/compiler/implementation/ssa/optimize.dart - Issue 10810043: Reenable GVN for fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10810043: Reenable GVN for fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/optimize.dart

diff --git a/lib/compiler/implementation/ssa/optimize.dart b/lib/compiler/implementation/ssa/optimize.dart

index 3245032367aa2fd1a21e06778c3b72451ab91be8..b1bc51d5e10797640849995591cb2bb8e1d3e849 100644

--- a/lib/compiler/implementation/ssa/optimize.dart

+++ b/lib/compiler/implementation/ssa/optimize.dart

@@ -999,6 +999,9 @@ class SsaGlobalValueNumberer implements OptimizationPhase {

if (dominator.id < id && id < dominated.id && !visited.contains(id)) {

visited.add(id);

changesFlags |= blockChangesFlags[id];

+ // Loop bodies might not be on the path from dominator to dominated,

+ // but they can invalidate values.

+ changesFlags |= loopChangesFlags[id];

changesFlags |= getChangesFlagsForDominatedBlock(dominator, block);

}