Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10810043: Reenable GVN for fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 9d7ed244a63e0eefadbe46eba9092e0e2b3a97aa..139bc118e7f7e8d02156fbb21a450486c4f7b4aa 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -1272,7 +1272,9 @@ class HInvokeInterceptor extends HInvokeStatic {
void prepareGvn() {
if (isLengthGetterOnStringOrArray()) {
+ setUseGvn();
clearAllSideEffects();
+ setDependsOnSomething();
} else {
setAllSideEffects();
}
@@ -1303,7 +1305,9 @@ class HFieldGet extends HFieldAccess {
accept(HVisitor visitor) => visitor.visitFieldGet(this);
void prepareGvn() {
+ setUseGvn();
clearAllSideEffects();
floitsch 2012/07/20 18:25:20 The original version (when GVN was enabled) did no
+ if (!isFinalOrConst) setDependsOnSomething();
}
int typeCode() => 27;
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698