Chromium Code Reviews Chromium Code Reviews
Issue 10809062:
Extensions Docs Server: Samples search and icons (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/common/extensions/docs/server2/templates/public/samples.html |
| diff --git a/chrome/common/extensions/docs/server2/templates/public/samples.html b/chrome/common/extensions/docs/server2/templates/public/samples.html |
| index 6feacf2ec7a3195a25c0c7f4eae5505746b03a48..06a48569a72ab8b3fd9d3c5453370740bfa005fd 100644 |
| --- a/chrome/common/extensions/docs/server2/templates/public/samples.html |
| +++ b/chrome/common/extensions/docs/server2/templates/public/samples.html |
| @@ -2,14 +2,29 @@ |
| <html> |
| <head> |
| {{+partials.header_head}} |
| + <link href="{{static}}/css/samples.css" rel="stylesheet" type="text/css"> |
| </head> |
| <body> |
| {{+partials.header_body}} |
| <div id="gc-container"> |
| {{+partials.sidenav}} |
| <div id="gc-pagecontent"> |
| - <h1>Samples</h1> |
| + <h1 class="page_title">Samples</h1> |
| + <div id="controls"> |
| + <div class="controlbox"> |
| + <strong>Filter by keyword:</strong> |
|
not at google - send to devlin
2012/07/24 01:09:55
we should be using styles rather than <strong>
cduvall
2012/07/24 20:14:47
Done.
|
| + <input autofocus="" type="search" id="search_input" placeholder="Type to search" onsearch="filterSamples();" onkeyup="filterSamples();"> |
|
not at google - send to devlin
2012/07/24 01:09:55
Having events declarative in here is nice, because
cduvall
2012/07/24 20:14:47
Done.
|
| + </div> |
| + <div class="controlbox"> |
| + <strong>Filter by API:</strong> |
|
not at google - send to devlin
2012/07/24 01:09:55
ditto
cduvall
2012/07/24 20:14:47
Done.
|
| + {{#api_list.chrome}} |
| + <span><a href="javascript:void(0);" onclick="setFilter('chrome.{{@}}')">chrome.{{@}}</a> </span> |
|
not at google - send to devlin
2012/07/24 01:09:55
ditto
btw, one other thing with this case: you'd
cduvall
2012/07/24 20:14:47
Putting the listener on the outer div was giving m
|
| + {{/}} |
|
not at google - send to devlin
2012/07/24 01:09:55
Also, this generated HTML that looks like
chrome.
cduvall
2012/07/24 20:14:47
Done.
|
| + </div> |
| + </div> |
| {{#samples.samples}} |
| + <div class="sample" tags="{{#api_calls}}{{name}} {{/}}"> |
| + <img class="icon" src="{{?icon}}{{path}}/{{icon}}{{:}}{{static}}/images/sample-default-icon.png{{/}}"> |
|
not at google - send to devlin
2012/07/24 01:09:55
this logic could be moved into the data source? Li
cduvall
2012/07/24 20:14:47
Done.
|
| <h2><a href="{{path}}.zip">{{name}}</a></h2> |
| {{description}} |
| <div> |
| @@ -28,9 +43,11 @@ |
| {{/}} |
| </ul> |
| </div> |
| + </div> |
| {{/samples.samples}} |
| </div> |
| </div> |
| </body> |
| {{+partials.footer}} |
| + <script src="{{static}}/js/sample_search.js" type="text/javascript"></script> |
|
not at google - send to devlin
2012/07/24 01:09:55
just samples.js? Match the name of the HTML/CSS?
|
| </html> |
