Chromium Code Reviews Chromium Code Reviews
Issue 10809062:
Extensions Docs Server: Samples search and icons (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 {{+partials.header_head}} | 4 {{+partials.header_head}} |
| 5 <link href="{{static}}/css/samples.css" rel="stylesheet" type="text/css"> | |
| 5 </head> | 6 </head> |
| 6 <body> | 7 <body> |
| 7 {{+partials.header_body}} | 8 {{+partials.header_body}} |
| 8 <div id="gc-container"> | 9 <div id="gc-container"> |
| 9 {{+partials.sidenav}} | 10 {{+partials.sidenav}} |
| 10 <div id="gc-pagecontent"> | 11 <div id="gc-pagecontent"> |
| 11 <h1>Samples</h1> | 12 <h1 class="page_title">Samples</h1> |
| 13 <div id="controls"> | |
| 14 <div class="controlbox"> | |
| 15 <strong>Filter by keyword:</strong> | |
|
not at google - send to devlin
2012/07/24 01:09:55
we should be using styles rather than <strong>
cduvall
2012/07/24 20:14:47
Done.
| |
| 16 <input autofocus="" type="search" id="search_input" placeholder="Typ e to search" onsearch="filterSamples();" onkeyup="filterSamples();"> | |
|
not at google - send to devlin
2012/07/24 01:09:55
Having events declarative in here is nice, because
cduvall
2012/07/24 20:14:47
Done.
| |
| 17 </div> | |
| 18 <div class="controlbox"> | |
| 19 <strong>Filter by API:</strong> | |
|
not at google - send to devlin
2012/07/24 01:09:55
ditto
cduvall
2012/07/24 20:14:47
Done.
| |
| 20 {{#api_list.chrome}} | |
| 21 <span><a href="javascript:void(0);" onclick="setFilter('chrome.{ {@}}')">chrome.{{@}}</a> </span> | |
|
not at google - send to devlin
2012/07/24 01:09:55
ditto
btw, one other thing with this case: you'd
cduvall
2012/07/24 20:14:47
Putting the listener on the outer div was giving m
| |
| 22 {{/}} | |
|
not at google - send to devlin
2012/07/24 01:09:55
Also, this generated HTML that looks like
chrome.
cduvall
2012/07/24 20:14:47
Done.
| |
| 23 </div> | |
| 24 </div> | |
| 12 {{#samples.samples}} | 25 {{#samples.samples}} |
| 26 <div class="sample" tags="{{#api_calls}}{{name}} {{/}}"> | |
| 27 <img class="icon" src="{{?icon}}{{path}}/{{icon}}{{:}}{{static}}/image s/sample-default-icon.png{{/}}"> | |
|
not at google - send to devlin
2012/07/24 01:09:55
this logic could be moved into the data source? Li
cduvall
2012/07/24 20:14:47
Done.
| |
| 13 <h2><a href="{{path}}.zip">{{name}}</a></h2> | 28 <h2><a href="{{path}}.zip">{{name}}</a></h2> |
| 14 {{description}} | 29 {{description}} |
| 15 <div> | 30 <div> |
| 16 <strong>Calls:</strong> | 31 <strong>Calls:</strong> |
| 17 <ul> | 32 <ul> |
| 18 {{#api_calls}} | 33 {{#api_calls}} |
| 19 <li><code><a href="{{link}}">{{name}}</a></code></li> | 34 <li><code><a href="{{link}}">{{name}}</a></code></li> |
| 20 {{/}} | 35 {{/}} |
| 21 </ul> | 36 </ul> |
| 22 </div> | 37 </div> |
| 23 <div> | 38 <div> |
| 24 <strong>Source Files:</strong> | 39 <strong>Source Files:</strong> |
| 25 <ul> | 40 <ul> |
| 26 {{#files}} | 41 {{#files}} |
| 27 <li><code><a href="{{path}}/{{@}}">{{@}}</a></code></li> | 42 <li><code><a href="{{path}}/{{@}}">{{@}}</a></code></li> |
| 28 {{/}} | 43 {{/}} |
| 29 </ul> | 44 </ul> |
| 30 </div> | 45 </div> |
| 46 </div> | |
| 31 {{/samples.samples}} | 47 {{/samples.samples}} |
| 32 </div> | 48 </div> |
| 33 </div> | 49 </div> |
| 34 </body> | 50 </body> |
| 35 {{+partials.footer}} | 51 {{+partials.footer}} |
| 52 <script src="{{static}}/js/sample_search.js" type="text/javascript"></script> | |
|
not at google - send to devlin
2012/07/24 01:09:55
just samples.js? Match the name of the HTML/CSS?
| |
| 36 </html> | 53 </html> |
| OLD | NEW |
