Issue 10809054: gdata: Remove use of GetGDataEntryByPath() from StartFileUploadOnUIThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10809054: gdata: Remove use of GetGDataEntryByPath() from StartFileUploadOnUIThread (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove use of GetGDataEntryByPath() from StartFileUploadOnUIThread The number of calles of GetGDataEntryByPath() is reduced from 19 to 18. StartFileUploadParams is introduced to overcome the limitation of Bind. BUG=137694 TEST=out/Release/unit_tests --gtest_filter=GData*; confirm uploading to drive works as before by "save image as" to Drive. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147964

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -25 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		2 chunks	+13 lines, -3 lines	2 comments	Download
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		3 chunks	+52 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

lgtm http://codereview.chromium.org/10809054/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.h File chrome/browser/chromeos/gdata/gdata_file_system.h (right): http://codereview.chromium.org/10809054/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.h#newcode176 chrome/browser/chromeos/gdata/gdata_file_system.h:176: struct StartFileUploadParams; So the reason for these params ...

8 years, 5 months ago (2012-07-23 22:01:45 UTC) #2

satorux1

8 years, 5 months ago (2012-07-23 22:02:49 UTC) #3

http://codereview.chromium.org/10809054/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10809054/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.h:176: struct
StartFileUploadParams;
On 2012/07/23 22:01:45, achuith.bhandarkar wrote:
> So the reason for these params is the Bind arg size limit?

yes.

Expand Messages | Collapse Messages