gdata: Remove use of GetGDataEntryByPath() from StartFileUploadOnUIThread

chrome/browser/chromeos/gdata/gdata_file_system.h

Index: chrome/browser/chromeos/gdata/gdata_file_system.h
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.h b/chrome/browser/chromeos/gdata/gdata_file_system.h
index fdd3f821a23d67d55c1d97ee8c485da72cb11a34..f6a26196fa0f6ee6ad023854614a27393152b644 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.h
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.h
@@ -172,6 +172,9 @@ class GDataFileSystem : public GDataFileSystemInterface,
   // Struct used to record UMA stats with FeedToFileResourceMap().
   struct FeedToFileResourceMapUmaStats;
 
+  // Struct used for StartFileUploadOnUIThread().
+  struct StartFileUploadParams;

[achuithb, 2012/07/23 22:01:45]

So the reason for these params is the Bind arg size limit?

[satorux1, 2012/07/23 22:02:49]

yes.

+
   // Finds entry object by |file_path| and returns the entry object.
   // Returns NULL if it does not find the entry.
   GDataEntry* GetGDataEntryByPath(const FilePath& file_path);
@@ -648,13 +651,20 @@ class GDataFileSystem : public GDataFileSystemInterface,
 
   // Kicks off file upload once it receives |file_size| and |content_type|.
   void StartFileUploadOnUIThread(
-      const FilePath& local_file,
-      const FilePath& remote_dest_file,
-      const FileOperationCallback& callback,
+      const StartFileUploadParams& params,
       GDataFileError* error,
       int64* file_size,
       std::string* content_type);
 
+  // Part of StartFileUploadOnUIThread(). Called after GetEntryInfoByPath()
+  // is complete.
+  void StartFileUploadOnUIThreadAfterGetEntryInfo(
+      const StartFileUploadParams& params,
+      int64 file_size,
+      std::string content_type,
+      GDataFileError error,
+      scoped_ptr<GDataEntryProto> entry_proto);
+
   // Cache intermediate callbacks, that run on calling thread, for above cache
   // tasks that were run on blocking pool.