move openMediaGalleryManager fn out of experimental.

move openMediaGalleryManager fn out of experimental.

BUG=110823
TEST=included

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148054

[Evan Stade, 2012-07-24 03:30:56]

I don't know why there's no
chrome/common/extensions/docs/extensions/mediaGalleries.html being generated.

[vandebo (ex-Chrome), 2012-07-24 04:07:05]

Initial comments.  Another pass through shortly, probably without anything more
to say.

http://codereview.chromium.org/10808093/diff/2002/chrome/browser/extensions/a...
File chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
(right):

http://codereview.chromium.org/10808093/diff/2002/chrome/browser/extensions/a...
chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc:15:
command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);
If we test experimental and non-experimental APIs in different test files, then
we can ditch the experimental flag on the stable API test.  Seems ok to clean up
later.

http://codereview.chromium.org/10808093/diff/2002/chrome/browser/extensions/a...
chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc:21: //
Tests that platform apps can use the chrome.app.window.* API.
Copy paste problem in comment.

http://codereview.chromium.org/10808093/diff/2002/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/media_galleries/test.js (right):

http://codereview.chromium.org/10808093/diff/2002/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/media_galleries/test.js:35: var result =
experimentalMediaGalleries.extractEmbeddedThumbnails({});
We could test experimental APIs in a different test file.

[vandebo (ex-Chrome), 2012-07-24 04:21:36]

LGTM with previous nits.

[Evan Stade, 2012-07-24 04:23:12]

ok, punting on the separation of tests.

http://codereview.chromium.org/10808093/diff/2002/chrome/browser/extensions/a...
File chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
(right):

http://codereview.chromium.org/10808093/diff/2002/chrome/browser/extensions/a...
chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc:21: //
Tests that platform apps can use the chrome.app.window.* API.
On 2012/07/24 04:07:05, vandebo wrote:
> Copy paste problem in comment.

Done.

[Evan Stade, 2012-07-24 04:30:37]

+kalman due to time zones. Could you take a look at this change, which just
moves a single function out of experimental?

[not at google - send to devlin, 2012-07-24 04:56:20]

lgtm, don't know what's going on with that documentation generation but seems
like the kind of thing that should be fixed.

http://codereview.chromium.org/10808093/diff/2002/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/media_galleries/test.js (right):

http://codereview.chromium.org/10808093/diff/2002/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/media_galleries/test.js:24:
chrome.test.runTests(tests);
I can see the code was already like this... but having multiple calls to
chrome.test.runTests is kind of dangerous, since it assumes it only ever gets
called once (look in apitest.js).

That said, am I going crazy, or does this function never even get called?

[Evan Stade, 2012-07-24 17:31:33]

http://codereview.chromium.org/10808093/diff/2002/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/media_galleries/test.js (right):

http://codereview.chromium.org/10808093/diff/2002/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/media_galleries/test.js:24:
chrome.test.runTests(tests);
On 2012/07/24 04:56:21, kalman wrote:
> I can see the code was already like this... but having multiple calls to
> chrome.test.runTests is kind of dangerous, since it assumes it only ever gets
> called once (look in apitest.js).
> 
> That said, am I going crazy, or does this function never even get called?

yea, I think you are right. It still passes locally if I remove it, but I'll add
a TODO to remove it for now just because I want to land this without another
pass by the trybots.

[Evan Stade, 2012-07-24 17:32:56]

well, I biffed the commit message, it should have been GetMediaFileSystems, not
openMediaGalleryManager