chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc - Issue 10808093: move openMediaGalleryManager fn out of experimental.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc

Issue 10808093: move openMediaGalleryManager fn out of experimental. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 80 chars Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_api.cc ('k') | chrome/common/extensions/api/api.gyp » ('j') | chrome/test/data/extensions/api_test/media_galleries/test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "chrome/browser/extensions/extension_apitest.h"	6 #include "chrome/browser/extensions/platform_app_browsertest_util.h"

7 #include "chrome/common/chrome_switches.h"	7 #include "chrome/common/chrome_switches.h"

8	8

9 namespace {	9 namespace {

10	10

11 class ExperimentalExtensionApiTest : public ExtensionApiTest {	11 class MediaGalleriesApiTest: public PlatformAppBrowserTest {

12 public:	12 public:

13 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {	13 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {

14 ExtensionApiTest::SetUpCommandLine(command_line);	14 PlatformAppBrowserTest::SetUpCommandLine(command_line);

15 command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);	15 command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);
	vandebo (ex-Chrome) 2012/07/24 04:07:05 If we test experimental and non-experimental APIs If we test experimental and non-experimental APIs in different test files, then we can ditch the experimental flag on the stable API test. Seems ok to clean up later.
16 }	16 }

17 };	17 };

18	18

19 } // namespace	19 } // namespace

20	20

21 IN_PROC_BROWSER_TEST_F(ExperimentalExtensionApiTest, MediaGalleries) {	21 // Tests that platform apps can use the chrome.app.window.* API.
	vandebo (ex-Chrome) 2012/07/24 04:07:05 Copy paste problem in comment. Copy paste problem in comment. Evan Stade 2012/07/24 04:23:12 Done. Show quoted text On 2012/07/24 04:07:05, vandebo wrote: > Copy paste problem in comment. Done.
22 ASSERT_TRUE(RunExtensionTest("media_galleries")) << message_;	22 IN_PROC_BROWSER_TEST_F(MediaGalleriesApiTest, MediaGalleries) {

	23 ASSERT_TRUE(RunPlatformAppTest("api_test/media_galleries")) << message_;

23 }	24 }

OLD	NEW