Issue 10808089: Merge 146897 - WebMediaPlayerImpl needs to own the audio source provider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10808089: Merge 146897 - WebMediaPlayerImpl needs to own the audio source provider. (Closed)

Created:
8 years, 5 months ago by scherkus (not reviewing)

Modified:
8 years, 5 months ago

Reviewers:
Raymond Toy (Google), Raymond Toy

CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1180/src/

Visibility:
Public.

More Reviews

Description

Merge 146897 - WebMediaPlayerImpl needs to own the audio source provider. WebMediaPlayerImpl needs to own the audio source provider to keep it from being destroyed too soon. BUG=132890 TEST=See test in bug report. Review URL: https://chromiumcodereview.appspot.com/10662030 TBR=rtoy@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147946

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -5 lines)			Patch
M	chrome/renderer/chrome_content_renderer_client.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/prerender/prerender_webmediaplayer.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/prerender/prerender_webmediaplayer.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/public/renderer/content_renderer_client.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
MM	content/public/renderer/content_renderer_client.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.h	View	3 chunks	+11 lines, -1 line	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

I compared this with the original patch.

LGTM.

Expand Messages | Collapse Messages