Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10808087: Remove use of PipelineStatus from BufferedDataSource and FileDataSource. (Closed)

Created:
8 years, 5 months ago by scherkus (not reviewing)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove use of PipelineStatus from BufferedDataSource and FileDataSource. You know what's better than passing back PIPELINE_OK and not-PIPELINE_OK? A boolean. BUG=126067 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147978

Patch Set 1 #

Total comments: 5

Patch Set 2 : status -> success #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -68 lines) Patch
M media/base/data_buffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/filters/file_data_source_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/pipeline_integration_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_wtl/movie.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/seek_tester/seek_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/buffered_data_source.h View 5 chunks +6 lines, -9 lines 0 comments Download
M webkit/media/buffered_data_source.cc View 7 chunks +12 lines, -24 lines 0 comments Download
M webkit/media/buffered_data_source_unittest.cc View 12 chunks +18 lines, -15 lines 0 comments Download
M webkit/media/webmediaplayer_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
8 years, 5 months ago (2012-07-23 20:57:46 UTC) #1
Ami GONE FROM CHROMIUM
Funny that this CL doesn't touch data_source.h... http://codereview.chromium.org/10808087/diff/1/media/tools/player_wtl/movie.cc File media/tools/player_wtl/movie.cc (right): http://codereview.chromium.org/10808087/diff/1/media/tools/player_wtl/movie.cc#newcode69 media/tools/player_wtl/movie.cc:69: if (!data_source->Initialize(url_utf8)) ...
8 years, 5 months ago (2012-07-23 21:11:05 UTC) #2
Ami GONE FROM CHROMIUM
oh, also LGTM % those nits.
8 years, 5 months ago (2012-07-23 21:11:13 UTC) #3
scherkus (not reviewing)
http://codereview.chromium.org/10808087/diff/1/media/tools/player_wtl/movie.cc File media/tools/player_wtl/movie.cc (right): http://codereview.chromium.org/10808087/diff/1/media/tools/player_wtl/movie.cc#newcode69 media/tools/player_wtl/movie.cc:69: if (!data_source->Initialize(url_utf8)) { On 2012/07/23 21:11:05, Ami Fischman wrote: ...
8 years, 5 months ago (2012-07-23 21:20:18 UTC) #4
Ami GONE FROM CHROMIUM
http://codereview.chromium.org/10808087/diff/1/media/tools/player_wtl/movie.cc File media/tools/player_wtl/movie.cc (right): http://codereview.chromium.org/10808087/diff/1/media/tools/player_wtl/movie.cc#newcode69 media/tools/player_wtl/movie.cc:69: if (!data_source->Initialize(url_utf8)) { On 2012/07/23 21:20:18, scherkus wrote: > ...
8 years, 5 months ago (2012-07-23 21:30:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/10808087/6002
8 years, 5 months ago (2012-07-23 21:35:16 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 22:57:32 UTC) #7 
Change committed as 147978

Powered by Google App Engine
This is Rietveld 408576698