Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: webkit/media/buffered_data_source_unittest.cc

Issue 10808087: Remove use of PipelineStatus from BufferedDataSource and FileDataSource. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: status -> success Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/buffered_data_source.cc ('k') | webkit/media/webmediaplayer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/buffered_data_source_unittest.cc
diff --git a/webkit/media/buffered_data_source_unittest.cc b/webkit/media/buffered_data_source_unittest.cc
index c33b7e3d76276bb2db6eb5bb207e5e31e84305d0..af1a863f8bcc7392399aa9da1418d22045612ff4 100644
--- a/webkit/media/buffered_data_source_unittest.cc
+++ b/webkit/media/buffered_data_source_unittest.cc
@@ -104,14 +104,17 @@ class BufferedDataSourceTest : public testing::Test {
view_->close();
}
- void Initialize(const char* url, media::PipelineStatus expected) {
+ MOCK_METHOD1(OnInitialize, void(bool));
+
+ void Initialize(const char* url, bool expected) {
GURL gurl(url);
response_generator_.reset(new TestResponseGenerator(gurl, kFileSize));
ExpectCreateResourceLoader();
- data_source_->Initialize(gurl,
- BufferedResourceLoader::kUnspecified,
- media::NewExpectedStatusCB(expected));
+ EXPECT_CALL(*this, OnInitialize(expected));
+ data_source_->Initialize(
+ gurl, BufferedResourceLoader::kUnspecified, base::Bind(
+ &BufferedDataSourceTest::OnInitialize, base::Unretained(this)));
message_loop_.RunAllPending();
bool is_http = gurl.SchemeIs(kHttpScheme) || gurl.SchemeIs(kHttpsScheme);
@@ -120,7 +123,7 @@ class BufferedDataSourceTest : public testing::Test {
// Helper to initialize tests with a valid 206 response.
void InitializeWith206Response() {
- Initialize(kHttpUrl, media::PIPELINE_OK);
+ Initialize(kHttpUrl, true);
EXPECT_CALL(host_, SetTotalBytes(response_generator_->content_length()));
Respond(response_generator_->Generate206(0));
@@ -128,7 +131,7 @@ class BufferedDataSourceTest : public testing::Test {
// Helper to initialize tests with a valid file:// response.
void InitializeWithFileResponse() {
- Initialize(kFileUrl, media::PIPELINE_OK);
+ Initialize(kFileUrl, true);
EXPECT_CALL(host_, SetTotalBytes(kFileSize));
EXPECT_CALL(host_, AddBufferedByteRange(0, kFileSize));
@@ -218,7 +221,7 @@ class BufferedDataSourceTest : public testing::Test {
};
TEST_F(BufferedDataSourceTest, Range_Supported) {
- Initialize(kHttpUrl, media::PIPELINE_OK);
+ Initialize(kHttpUrl, true);
EXPECT_CALL(host_, SetTotalBytes(response_generator_->content_length()));
Respond(response_generator_->Generate206(0));
@@ -229,7 +232,7 @@ TEST_F(BufferedDataSourceTest, Range_Supported) {
}
TEST_F(BufferedDataSourceTest, Range_InstanceSizeUnknown) {
- Initialize(kHttpUrl, media::PIPELINE_OK);
+ Initialize(kHttpUrl, true);
Respond(response_generator_->Generate206(
0, TestResponseGenerator::kNoContentRangeInstanceSize));
@@ -240,7 +243,7 @@ TEST_F(BufferedDataSourceTest, Range_InstanceSizeUnknown) {
}
TEST_F(BufferedDataSourceTest, Range_NotFound) {
- Initialize(kHttpUrl, media::PIPELINE_ERROR_NETWORK);
+ Initialize(kHttpUrl, false);
Respond(response_generator_->Generate404());
EXPECT_FALSE(data_source_->loading());
@@ -248,7 +251,7 @@ TEST_F(BufferedDataSourceTest, Range_NotFound) {
}
TEST_F(BufferedDataSourceTest, Range_NotSupported) {
- Initialize(kHttpUrl, media::PIPELINE_OK);
+ Initialize(kHttpUrl, true);
EXPECT_CALL(host_, SetTotalBytes(response_generator_->content_length()));
Respond(response_generator_->Generate200());
@@ -260,7 +263,7 @@ TEST_F(BufferedDataSourceTest, Range_NotSupported) {
// Special carve-out for Apache versions that choose to return a 200 for
// Range:0- ("because it's more efficient" than a 206)
TEST_F(BufferedDataSourceTest, Range_SupportedButReturned200) {
- Initialize(kHttpUrl, media::PIPELINE_OK);
+ Initialize(kHttpUrl, true);
EXPECT_CALL(host_, SetTotalBytes(response_generator_->content_length()));
WebURLResponse response = response_generator_->Generate200();
response.setHTTPHeaderField(WebString::fromUTF8("Accept-Ranges"),
@@ -273,7 +276,7 @@ TEST_F(BufferedDataSourceTest, Range_SupportedButReturned200) {
}
TEST_F(BufferedDataSourceTest, Range_MissingContentRange) {
- Initialize(kHttpUrl, media::PIPELINE_ERROR_NETWORK);
+ Initialize(kHttpUrl, false);
Respond(response_generator_->Generate206(
0, TestResponseGenerator::kNoContentRange));
@@ -282,7 +285,7 @@ TEST_F(BufferedDataSourceTest, Range_MissingContentRange) {
}
TEST_F(BufferedDataSourceTest, Range_MissingContentLength) {
- Initialize(kHttpUrl, media::PIPELINE_OK);
+ Initialize(kHttpUrl, true);
// It'll manage without a Content-Length response.
EXPECT_CALL(host_, SetTotalBytes(response_generator_->content_length()));
@@ -295,7 +298,7 @@ TEST_F(BufferedDataSourceTest, Range_MissingContentLength) {
}
TEST_F(BufferedDataSourceTest, Range_WrongContentRange) {
- Initialize(kHttpUrl, media::PIPELINE_ERROR_NETWORK);
+ Initialize(kHttpUrl, false);
// Now it's done and will fail.
Respond(response_generator_->Generate206(1337));
@@ -452,7 +455,7 @@ TEST_F(BufferedDataSourceTest, File_TooManyRetries) {
}
TEST_F(BufferedDataSourceTest, File_InstanceSizeUnknown) {
- Initialize(kFileUrl, media::PIPELINE_ERROR_NETWORK);
+ Initialize(kFileUrl, false);
EXPECT_FALSE(data_source_->downloading());
Respond(response_generator_->GenerateFileResponse(-1));
« no previous file with comments | « webkit/media/buffered_data_source.cc ('k') | webkit/media/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698