Issue 10808072: ui: No need to typedef testing::Test in unittests.

Issue 10808072: ui: No need to typedef testing::Test in unittests. (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, jonathan.backer, Ian Vollick, ben+watch_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui: No need to typedef testing::Test in unittests. TEST() macro should be used instead. TEST=ui_unittests R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148710

Patch Set 1 : #

Total comments: 2

Patch Set 2 : typos #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -58 lines)			Patch
M	ui/aura/bench/bench_main.cc	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/aura/window_property.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_mac.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/base/resource/resource_bundle_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/text/text_elider.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/win/hwnd_subclass_unittest.cc	View		4 chunks	+5 lines, -6 lines	0 comments	Download
M	ui/compositor/compositor.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/compositor/scoped_layer_animation_settings.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	ui/gfx/canvas_skia.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/font_list_unittest.cc	View		17 chunks	+18 lines, -20 lines	0 comments	Download
M	ui/gfx/image/image_skia_operations.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/image/image_skia_unittest.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	ui/gfx/screen_unittest.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	ui/gl/gl_context_glx.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_implementation_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_implementation_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_implementation_mac.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_implementation_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_surface_glx.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gl/gl_surface_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/surface/accelerated_surface_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/ui_controls/ui_controls_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 5 months ago (2012-07-23 15:52:13 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10808072/diff/2001/ui/aura/window_prop...
File ui/aura/window_property.h (right):

https://chromiumcodereview.appspot.com/10808072/diff/2001/ui/aura/window_prop...
ui/aura/window_property.h:31: //    // only in a specific file. This will define
the property in unnamed
an unnamed

https://chromiumcodereview.appspot.com/10808072/diff/2001/ui/base/text/text_e...
File ui/base/text/text_elider.cc (right):

https://chromiumcodereview.appspot.com/10808072/diff/2001/ui/base/text/text_e...
ui/base/text/text_elider.cc:8: // in this file using helper classes in the
unnamed namespace.
'in the' -> 'in an'

Expand Messages | Collapse Messages