Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 10808046: Disable blurring for extension bubbles (Closed)

Created:
6 years, 11 months ago by sail
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Disable blurring for extension bubbles Extension bubbles in HiDPI mode were drawing incorrectly. The problem was that the blur filter we placed on bubble windows was interfering with OpenGL drawing. I've filed an Apple bug about this: http://openradar.appspot.com/11920246 In the meantime this CL disables the blur filter for extension bubbles. BUG=135382 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147628

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 3 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
LGTM Thanks! https://chromiumcodereview.appspot.com/10808046/diff/1/chrome/browser/ui/cocoa/info_bubble_window.h File chrome/browser/ui/cocoa/info_bubble_window.h (right): https://chromiumcodereview.appspot.com/10808046/diff/1/chrome/browser/ui/cocoa/info_bubble_window.h#newcode33 chrome/browser/ui/cocoa/info_bubble_window.h:33: @property(nonatomic) BOOL hasBlurredBackground; "// Only has an ...
6 years, 11 months ago (2012-07-20 07:53:23 UTC) #1
sail
https://chromiumcodereview.appspot.com/10808046/diff/1/chrome/browser/ui/cocoa/info_bubble_window.h File chrome/browser/ui/cocoa/info_bubble_window.h (right): https://chromiumcodereview.appspot.com/10808046/diff/1/chrome/browser/ui/cocoa/info_bubble_window.h#newcode33 chrome/browser/ui/cocoa/info_bubble_window.h:33: @property(nonatomic) BOOL hasBlurredBackground; On 2012/07/20 07:53:23, Nico wrote: > ...
6 years, 11 months ago (2012-07-20 08:00:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/10808046/2002
6 years, 11 months ago (2012-07-20 08:00:37 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2012-07-20 09:17:13 UTC) #4
Change committed as 147628

Powered by Google App Engine
This is Rietveld 408576698