Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 10808046: Disable blurring for extension bubbles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/info_bubble_window.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "chrome/browser/debugger/devtools_window.h" 9 #include "chrome/browser/debugger/devtools_window.h"
10 #include "chrome/browser/extensions/extension_host.h" 10 #include "chrome/browser/extensions/extension_host.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 arrowLocation:(info_bubble::BubbleArrowLocation)arrowLocation 129 arrowLocation:(info_bubble::BubbleArrowLocation)arrowLocation
130 devMode:(BOOL)devMode { 130 devMode:(BOOL)devMode {
131 scoped_nsobject<InfoBubbleWindow> window( 131 scoped_nsobject<InfoBubbleWindow> window(
132 [[InfoBubbleWindow alloc] 132 [[InfoBubbleWindow alloc]
133 initWithContentRect:ui::kWindowSizeDeterminedLater 133 initWithContentRect:ui::kWindowSizeDeterminedLater
134 styleMask:NSBorderlessWindowMask 134 styleMask:NSBorderlessWindowMask
135 backing:NSBackingStoreBuffered 135 backing:NSBackingStoreBuffered
136 defer:YES]); 136 defer:YES]);
137 if (!window.get()) 137 if (!window.get())
138 return nil; 138 return nil;
139
140 // Don't blur the extension window background. This can interfer with OpenGL
141 // drawing on the window. See http://openradar.appspot.com/11920246
142 [window setHasBlurredBackground:NO];
143
139 anchoredAt = [parentWindow convertBaseToScreen:anchoredAt]; 144 anchoredAt = [parentWindow convertBaseToScreen:anchoredAt];
140 if ((self = [super initWithWindow:window 145 if ((self = [super initWithWindow:window
141 parentWindow:parentWindow 146 parentWindow:parentWindow
142 anchoredAt:anchoredAt])) { 147 anchoredAt:anchoredAt])) {
143 host_.reset(host); 148 host_.reset(host);
144 beingInspected_ = devMode; 149 beingInspected_ = devMode;
145 150
146 InfoBubbleView* view = self.bubble; 151 InfoBubbleView* view = self.bubble;
147 [view setArrowLocation:arrowLocation]; 152 [view setArrowLocation:arrowLocation];
148 153
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 return minSize; 374 return minSize;
370 } 375 }
371 376
372 // Private (TestingAPI) 377 // Private (TestingAPI)
373 + (NSSize)maxPopupSize { 378 + (NSSize)maxPopupSize {
374 NSSize maxSize = {ExtensionViewMac::kMaxWidth, ExtensionViewMac::kMaxHeight}; 379 NSSize maxSize = {ExtensionViewMac::kMaxWidth, ExtensionViewMac::kMaxHeight};
375 return maxSize; 380 return maxSize;
376 } 381 }
377 382
378 @end 383 @end
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/info_bubble_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698