Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 10807077: Merge 123259 - [chromium] CSS tweaks to media controls to prevent styles from being overridden (Closed)

Created:
8 years, 5 months ago by scherkus (not reviewing)
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 123259 - [chromium] CSS tweaks to media controls to prevent styles from being overridden https://bugs.webkit.org/show_bug.cgi?id=91802 Reviewed by Eric Carlson. Source/WebCore: Having the buttons declared as inline caused them to not be included in the box layout, resulting in styles set outside the media element to affect the position of the buttons. In a similar vein, it was also possible to override the font-style attribute for the time display. Test: media/controls-styling-strict.html * css/mediaControlsChromium.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): LayoutTests: * media/controls-styling-strict.html: Added. * platform/chromium-linux/media/controls-styling-strict-expected.png: Added. * platform/chromium-linux/media/controls-styling-strict-expected.txt: Added. TBR=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10376 lines, -24 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +6083 lines, -0 lines 0 comments Download
A + LayoutTests/media/controls-styling-strict.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 2 chunks +123 lines, -22 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +4167 lines, -0 lines 0 comments Download
M Source/WebCore/css/mediaControlsChromium.css View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scherkus (not reviewing)
8 years, 5 months ago (2012-07-23 21:04:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698