Refactor the setuid sandbox client code to its own class.

Create a new SetuidSandboxClient class.

We move the setuid sandbox "client" code to its own location in
/sandbox/linux/suid/client and we create a SetuidSandboxClient class
to use it.

NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147993

[jln (very slow on Chromium), 2012-07-20 22:06:19]

A new SetuidSandboxClient class to cleanup a lot of stuff.

[Jorge Lucangeli Obes, 2012-07-23 20:23:44]

sandbox/linux/suid/sandbox.c LGTM

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
File sandbox/linux/suid/client/setuid_sandbox_client.cc (right):

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.cc:138: LOG(ERROR) << "Failed to
write to chroot pipe: " << errno;
PLOG(ERROR)?

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.cc:146: LOG(ERROR) << "Failed to
wait for setuid helper to die " << errno;
PLOG

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.cc:152: LOG(ERROR) << "Failed to
read from chroot pipe: " << errno;
PLOG

[Markus (顧孟勤), 2012-07-23 21:06:30]

lgtm

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
File sandbox/linux/suid/client/setuid_sandbox_client.h (right):

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.h:32: // Did we get launched
through an up to date setuid binary ?
Minor nit. I would put blank lines here to make things a little easier to read

[jln (very slow on Chromium), 2012-07-23 21:32:14]

Thanks!

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
File sandbox/linux/suid/client/setuid_sandbox_client.cc (right):

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.cc:138: LOG(ERROR) << "Failed to
write to chroot pipe: " << errno;
On 2012/07/23 20:23:50, Jorge Lucangeli Obes wrote:
> PLOG(ERROR)?

Done.

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.cc:146: LOG(ERROR) << "Failed to
wait for setuid helper to die " << errno;
On 2012/07/23 20:23:50, Jorge Lucangeli Obes wrote:
> PLOG

Done.

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.cc:152: LOG(ERROR) << "Failed to
read from chroot pipe: " << errno;
On 2012/07/23 20:23:50, Jorge Lucangeli Obes wrote:
> PLOG

Done.

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
File sandbox/linux/suid/client/setuid_sandbox_client.h (right):

https://chromiumcodereview.appspot.com/10807059/diff/28/sandbox/linux/suid/cl...
sandbox/linux/suid/client/setuid_sandbox_client.h:32: // Did we get launched
through an up to date setuid binary ?
On 2012/07/23 21:06:30, Markus (顧孟勤) wrote:
> Minor nit. I would put blank lines here to make things a little easier to read

Done. I've put one to separate ChrootMe from the Is* method, I think it's
somewhat readable now.

[commit-bot: I haz the power, 2012-07-23 21:33:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10807059/13001

[commit-bot: I haz the power, 2012-07-23 21:33:50]

Presubmit check for 10807059-13001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser
    base

Presubmit checks took 1.1s to calculate.

[jln (very slow on Chromium), 2012-07-23 21:43:53]

Hi Brett,

do you mind approving this tiny change to /base?

(Also Rubberstamp for content/browser would be convenient since strangely Markus
and I are missing from that owner file. cf.
https://chromiumcodereview.appspot.com/10806076/)

Julien

[brettw, 2012-07-23 21:50:44]

remove code from base -> auto LGTM

[commit-bot: I haz the power, 2012-07-23 22:09:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10807059/13001

[commit-bot: I haz the power, 2012-07-23 23:31:08]

Try job failure for 10807059-13001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-23 23:36:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10807059/13001

[commit-bot: I haz the power, 2012-07-23 23:36:42]

Change committed as 147993