Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: sandbox/linux/suid/suid_unsafe_environment_variables.h

Issue 10807059: Refactor the setuid sandbox client code to its own class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer's comments and other minor nits. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sandbox/linux/suid/sandbox.c ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // This is a list of environment variables which the ELF loader unsets when
6 // loading a SUID binary. Because they are unset rather than just ignored, they
7 // aren't passed to child processes of SUID processes either.
8 //
9 // We need to save these environment variables before running a SUID sandbox
10 // and restore them before running child processes (but after dropping root).
11 //
12 // List gathered from glibc sources (00ebd7ed58df389a78e41dece058048725cb585e):
13 // sysdeps/unix/sysv/linux/i386/dl-librecon.h
14 // sysdeps/generic/unsecvars.h
15
16 #ifndef SANDBOX_LINUX_SUID_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
17 #define SANDBOX_LINUX_SUID_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
18
19 static const char* kSUIDUnsafeEnvironmentVariables[] = {
20 "LD_AOUT_LIBRARY_PATH",
21 "LD_AOUT_PRELOAD",
22 "GCONV_PATH",
23 "GETCONF_DIR",
24 "HOSTALIASES",
25 "LD_AUDIT",
26 "LD_DEBUG",
27 "LD_DEBUG_OUTPUT",
28 "LD_DYNAMIC_WEAK",
29 "LD_LIBRARY_PATH",
30 "LD_ORIGIN_PATH",
31 "LD_PRELOAD",
32 "LD_PROFILE",
33 "LD_SHOW_AUXV",
34 "LD_USE_LOAD_BIAS",
35 "LOCALDOMAIN",
36 "LOCPATH",
37 "MALLOC_TRACE",
38 "NIS_PATH",
39 "NLSPATH",
40 "RESOLV_HOST_CONF",
41 "RES_OPTIONS",
42 "TMPDIR",
43 "TZDIR",
44 NULL,
45 };
46
47 // Return a malloc allocated string containing the 'saved' environment variable
48 // name for a given environment variable.
49 static inline char* SandboxSavedEnvironmentVariable(const char* envvar) {
50 const size_t envvar_len = strlen(envvar);
51 const size_t saved_envvarlen = envvar_len + 1 /* NUL terminator */ +
52 8 /* strlen("SANDBOX_") */;
53 char* const saved_envvar = (char*) malloc(saved_envvarlen);
54 if (!saved_envvar)
55 return NULL;
56
57 memcpy(saved_envvar, "SANDBOX_", 8);
58 memcpy(saved_envvar + 8, envvar, envvar_len);
59 saved_envvar[8 + envvar_len] = 0;
60
61 return saved_envvar;
62 }
63
64 #endif // SANDBOX_LINUX_SUID_SUID_UNSAFE_ENVIRONMENT_VARIABLES_H_
OLDNEW
« no previous file with comments | « sandbox/linux/suid/sandbox.c ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698