Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1875)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 10807047: Create content\public\test\test_utils.h to hold common test classes that are used by unit and brows… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
===================================================================
--- chrome/browser/ssl/ssl_browser_tests.cc (revision 147577)
+++ chrome/browser/ssl/ssl_browser_tests.cc (working copy)
@@ -190,7 +190,7 @@
void ProceedThroughInterstitial(WebContents* tab) {
InterstitialPage* interstitial_page = tab->GetInterstitialPage();
ASSERT_TRUE(interstitial_page);
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
interstitial_page->Proceed();
@@ -486,7 +486,7 @@
// Now go back so that a page is in the forward history.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
tab->GetController().GoBack();
@@ -504,7 +504,7 @@
// Simulate user clicking and holding on forward button.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
tab->GetController().GoToOffset(1);
@@ -638,7 +638,7 @@
// Now, start a transition to dangerous download.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
chrome::NavigateParams navigate_params(browser(), url_dangerous,
@@ -653,7 +653,7 @@
ASSERT_TRUE(tab != NULL);
ASSERT_TRUE(tab->GetInterstitialPage() != NULL);
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
chrome::NOTIFICATION_DOWNLOAD_INITIATED,
content::NotificationService::AllSources());
tab->GetInterstitialPage()->Proceed();
@@ -804,7 +804,7 @@
params.disposition = NEW_FOREGROUND_TAB;
params.tabstrip_index = 0;
params.source_contents = tab1;
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
chrome::Navigate(&params);
@@ -846,7 +846,7 @@
chrome::NavigateParams params(browser(), url, content::PAGE_TRANSITION_TYPED);
params.disposition = NEW_FOREGROUND_TAB;
params.source_contents = tab1;
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
chrome::Navigate(&params);
@@ -1025,7 +1025,7 @@
// Let's add another tab to make sure the browser does not exit when we close
// the first tab.
GURL url = test_server()->GetURL("files/ssl/google.html");
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
chrome::AddSelectedTabWithURL(browser(), url, content::PAGE_TRANSITION_TYPED);
@@ -1167,7 +1167,7 @@
bool success = false;
// Now navigate inside the frame.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
@@ -1183,7 +1183,7 @@
// Now let's hit a bad page.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
@@ -1209,7 +1209,7 @@
// Now go back, our state should still be OK.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
tab->GetController().GoBack();
@@ -1219,7 +1219,7 @@
// Navigate to a page served over HTTP.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
@@ -1235,7 +1235,7 @@
// Go back, our state should be unchanged.
{
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
tab->GetController().GoBack();
@@ -1266,7 +1266,7 @@
// Navigate to a good frame.
bool success = false;
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
@@ -1303,7 +1303,7 @@
// Now navigate inside the frame to a secure HTTPS frame.
{
bool success = false;
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
@@ -1320,7 +1320,7 @@
// Now navigate to a bad HTTPS frame.
{
bool success = false;
- ui_test_utils::WindowedNotificationObserver observer(
+ content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::Source<NavigationController>(&tab->GetController()));
EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(
« no previous file with comments | « chrome/browser/sessions/tab_restore_service_browsertest.cc ('k') | chrome/browser/tab_restore_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698