Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10807047: Create content\public\test\test_utils.h to hold common test classes that are used by unit and brows… (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
CC:
chromium-reviews, MAD, sadrul, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, yoshiki+watch_chromium.org, rdsmith+dwatch_chromium.org, dcheng, rginda+watch_chromium.org, scheib+watch_chromium.org, dmazzoni+watch_chromium.org, Ilya Sherman, cbentzel+watch_chromium.org, jar (doing other things), ben+watch_chromium.org, aboxhall+watch_chromium.org, stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, dbeam+watch-ntp_chromium.org, jennb, dtseng+watch_chromium.org, browser-components-watch_chromium.org, yuzo+watch_chromium.org, gavinp+prer_chromium.org, jianli, oshima+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, mihaip-chromium-reviews_chromium.org, hashimoto+watch_chromium.org, Dmitry Titov, davidbarr+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, Satish, davemoore+watch_chromium.org, dyu1, estade+watch_chromium.org, James Su, mmenke, jshin+watch_chromium.org
Visibility:
Public.

Description

Create content\public\test\test_utils.h to hold common test classes that are used by unit and browser tests. unit tests shouldn't be including ui_test_utils.h. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147602

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -580 lines) Patch
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 2 20 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_popup_view_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_encoding_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_main_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/oom_priority_manager_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_apitest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/lazy_background_page_test_util.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/fast_shutdown_browsertest.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/metrics/metrics_service_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_interative_uitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/repost_form_warning_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_browsertest.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 16 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/tab_restore_browsertest.cc View 1 2 10 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 13 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 14 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_test.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/docked_panel_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/old_docked_panel_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_browsertest.cc View 1 2 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/panel_cocoa_unittest.mm View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/test_panel_active_state_observer.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/test_panel_active_state_observer.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_web_dialog_observer.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/base/test_web_dialog_observer.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/tracing.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 2 10 chunks +9 lines, -91 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 22 chunks +27 lines, -75 lines 0 comments Download
M chrome/test/perf/rendering/throughput_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 2 15 chunks +15 lines, -15 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
A content/public/test/test_utils.h View 1 1 chunk +112 lines, -0 lines 0 comments Download
M content/test/browser_test_utils.cc View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
M content/test/content_browser_test_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_navigation_observer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A content/test/test_utils.cc View 1 1 chunk +113 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698