HiDPI: Scale viewport for pepper flash fullscreen

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index d56d8f2030d2564924a26e742074c5031878f3cb..3c26a1e717dd66f8b3cab1e88c1185d8abe91e30 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1706,7 +1706,7 @@ RenderWidgetFullscreenPepper* RenderViewImpl::CreatePepperFullscreenContainer(
   if (webview() && webview()->mainFrame())
     active_url = GURL(webview()->mainFrame()->document().url());
   RenderWidgetFullscreenPepper* widget = RenderWidgetFullscreenPepper::Create(
-      routing_id_, plugin, active_url);
+      routing_id_, plugin, active_url, screen_info_);

[Nico, 2012/07/21 16:55:15]

As far as I can tell, this doesn't handle DPI changes at run time (this happens
e.g. when you switch between a regular resolution and a hidpi resolution in
system preferences on a lodpi mbp with hidpi resolutions enabled in
quartzdebug).

Is there any advantage in passing through screen_info_ instead of just the
display scale factor? (i don't mind either way, just curious)

[sail, 2012/07/25 18:16:02]

From what I can tell RenderWidget should get an updated device scale factor when
the DPI changes.

Here's what I tried:
   - on a retina scree at 2x scale factor play a youtube video
   - switch the display to 1x scale factor. Verified that the youtube page still
looks correct
    - switch to fullscreen, verify everything looks correct
    - while still in fullscreen change to 1x scale factor. Verified that the
fullscreen youtube video still looks correct.
RenderWidgetFullscreenPepper derives from RenderWidget which takes a ScreenInfo
object. RenderWidget::RenderWidget() uses the screen info to calculate the
initial device scale factor.

   widget->show(WebKit::WebNavigationPolicyIgnore);
   return widget;
 }