HiDPI: Scale viewport for pepper flash fullscreen

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 1688 matching lines @@
       new ExternalPopupMenu(this, popup_menu_info, popup_menu_client));
   return external_popup_menu_.get();
 }
 
 RenderWidgetFullscreenPepper* RenderViewImpl::CreatePepperFullscreenContainer(
     webkit::ppapi::PluginInstance* plugin) {
   GURL active_url;
   if (webview() && webview()->mainFrame())
     active_url = GURL(webview()->mainFrame()->document().url());
   RenderWidgetFullscreenPepper* widget = RenderWidgetFullscreenPepper::Create(
-      routing_id_, plugin, active_url);
+      routing_id_, plugin, active_url, screen_info_);

[Nico, 2012/07/21 16:55:15]

As far as I can tell, this doesn't handle DPI changes at run time (this happens
e.g. when you switch between a regular resolution and a hidpi resolution in
system preferences on a lodpi mbp with hidpi resolutions enabled in
quartzdebug).

Is there any advantage in passing through screen_info_ instead of just the
display scale factor? (i don't mind either way, just curious)

[sail, 2012/07/25 18:16:02]

From what I can tell RenderWidget should get an updated device scale factor when
the DPI changes.

Here's what I tried:
   - on a retina scree at 2x scale factor play a youtube video
   - switch the display to 1x scale factor. Verified that the youtube page still
looks correct
    - switch to fullscreen, verify everything looks correct
    - while still in fullscreen change to 1x scale factor. Verified that the
fullscreen youtube video still looks correct.
RenderWidgetFullscreenPepper derives from RenderWidget which takes a ScreenInfo
object. RenderWidget::RenderWidget() uses the screen info to calculate the
initial device scale factor.

   widget->show(WebKit::WebNavigationPolicyIgnore);
   return widget;
 }
 
 WebStorageNamespace* RenderViewImpl::createSessionStorageNamespace(
     unsigned quota) {
   CHECK(session_storage_namespace_id_ !=
         dom_storage::kInvalidSessionStorageNamespaceId);
   return new WebStorageNamespaceImpl(session_storage_namespace_id_);
 }
@@ skipping 3960 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_);
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_ = new JavaBridgeDispatcher(this);
 #endif
 }