Issue 10806080: ARM: Rename the "new_eip" field in NaClThreadContext to "new_prog_ctr"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10806080: ARM: Rename the "new_eip" field in NaClThreadContext to "new_prog_ctr" (Closed)

Created:
8 years, 5 months ago by Mark Seaborn

Modified:
8 years, 5 months ago

Reviewers:
bsy

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

ARM: Rename the "new_eip" field in NaClThreadContext to "new_prog_ctr" The name "new_eip" does not make much sense for ARM. This renaming was done for x86-32 in the past, but incompletely, so we are finishing it in this change. BUG=none TEST=build Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9270

Patch Set 1 #

Patch Set 2 : Retry upload #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase + copyright #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
M	src/trusted/service_runtime/arch/arm/nacl_switch.S	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/trusted/service_runtime/arch/arm/nacl_switch_to_app_arm.c	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/trusted/service_runtime/arch/arm/sel_rt.h	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/trusted/service_runtime/arch/arm/sel_rt.c	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/trusted/service_runtime/arch/x86_32/nacl_switch_32.S	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/trusted/service_runtime/arch/x86_32/sel_rt_32.h	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages