Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10806072: Refactor chrome.pageCapture to use JSON schema compiler (Closed)

Created:
8 years, 5 months ago by mitchellwrosen
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactor chrome.pageCapture to use JSON schema compiler BUG=121174 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149110

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/extensions/api/page_capture/page_capture_api.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 4 chunks +8 lines, -10 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mitchellwrosen
8 years, 5 months ago (2012-07-23 20:49:37 UTC) #1
mitchellwrosen
8 years, 4 months ago (2012-07-30 20:56:06 UTC) #2
Mihai Parparita -not on Chrome
https://chromiumcodereview.appspot.com/10806072/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc File chrome/browser/extensions/api/page_capture/page_capture_api.cc (left): https://chromiumcodereview.appspot.com/10806072/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc#oldcode64 chrome/browser/extensions/api/page_capture/page_capture_api.cc:64: EXTENSION_FUNCTION_VALIDATE(args->GetInteger("tabId", &tab_id_)); Seems like you still need to populate ...
8 years, 4 months ago (2012-07-30 23:51:26 UTC) #3
mitchellwrosen
https://chromiumcodereview.appspot.com/10806072/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc File chrome/browser/extensions/api/page_capture/page_capture_api.cc (left): https://chromiumcodereview.appspot.com/10806072/diff/1/chrome/browser/extensions/api/page_capture/page_capture_api.cc#oldcode64 chrome/browser/extensions/api/page_capture/page_capture_api.cc:64: EXTENSION_FUNCTION_VALIDATE(args->GetInteger("tabId", &tab_id_)); On 2012/07/30 23:51:26, Mihai Parparita wrote: > ...
8 years, 4 months ago (2012-07-31 00:22:29 UTC) #4
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-07-31 00:24:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10806072/5001
8 years, 4 months ago (2012-07-31 00:25:09 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 01:41:35 UTC) #7 
Change committed as 149110

Powered by Google App Engine
This is Rietveld 408576698