Refactor chrome.pageCapture to use JSON schema compiler

chrome/browser/extensions/api/page_capture/page_capture_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/page_capture/page_capture_api.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
+#include "chrome/common/extensions/api/page_capture.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 
 #include <limits>
 
 using content::BrowserThread;
 using content::ChildProcessSecurityPolicy;
 using content::WebContents;
 using extensions::PageCaptureSaveAsMHTMLFunction;
 using webkit_blob::ShareableFileReference;
 
+namespace SaveAsMHTML = extensions::api::page_capture::SaveAsMHTML;
+
 namespace {
 
 // Error messages.
 const char* const kFileTooBigError = "The MHTML file generated is too big.";
 const char* const kMHTMLGenerationFailedError = "Failed to generate MHTML.";
 const char* const kSizeRetrievalError =
     "Failed to retrieve size of generated MHTML.";
 const char* const kTemporaryFileError = "Failed to create a temporary file.";
 const char* const kTabClosedError = "Cannot find the tab for thie request.";
 
 }  // namespace
 
 static PageCaptureSaveAsMHTMLFunction::TestDelegate* test_delegate_ = NULL;
 
 PageCaptureSaveAsMHTMLFunction::PageCaptureSaveAsMHTMLFunction() : tab_id_(0) {
 }
 
 PageCaptureSaveAsMHTMLFunction::~PageCaptureSaveAsMHTMLFunction() {
   if (mhtml_file_.get()) {
     BrowserThread::ReleaseSoon(BrowserThread::IO, FROM_HERE,
                                mhtml_file_.release());
   }
 }
 
 void PageCaptureSaveAsMHTMLFunction::SetTestDelegate(TestDelegate* delegate) {
   test_delegate_ = delegate;
 }
 
 bool PageCaptureSaveAsMHTMLFunction::RunImpl() {
-  DictionaryValue* args;
-  EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(0, &args));
-
-  if (!args->HasKey("tabId"))
-    return false;
-
-  EXTENSION_FUNCTION_VALIDATE(args->GetInteger("tabId", &tab_id_));

[Mihai Parparita -not on Chrome, 2012/07/30 23:51:26]

Seems like you still need to populate the tab_id_ member.

[mitchellwrosen, 2012/07/31 00:22:29]

Whoops, my mistake. You're right.

+  scoped_ptr<SaveAsMHTML::Params> params(SaveAsMHTML::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
 
   AddRef();  // Balanced in ReturnFailure/ReturnSuccess()
 
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&PageCaptureSaveAsMHTMLFunction::CreateTemporaryFile, this));
   return true;
 }
 
 bool PageCaptureSaveAsMHTMLFunction::OnMessageReceivedFromRenderView(
@@ skipping 117 matching lines @@
 WebContents* PageCaptureSaveAsMHTMLFunction::GetWebContents() {
   Browser* browser = NULL;
   TabContents* tab_contents = NULL;
 
   if (!ExtensionTabUtil::GetTabById(tab_id_, profile(), include_incognito(),
       &browser, NULL, &tab_contents, NULL)) {
     return NULL;
   }
   return tab_contents->web_contents();
 }