Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1980)

Unified Diff: samples/third_party/dromaeo/tests/dom-query-html.dart

Issue 10806016: Cleanup queryAll to return List<Element>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/third_party/dromaeo/tests/dom-query-html.dart
diff --git a/samples/third_party/dromaeo/tests/dom-query-html.dart b/samples/third_party/dromaeo/tests/dom-query-html.dart
index e9d3eb99e853f5910db8ef9b11c2dc841d35cb2c..00437b1d39d60c44140d82b89b04e6082d28c8b0 100644
--- a/samples/third_party/dromaeo/tests/dom-query-html.dart
+++ b/samples/third_party/dromaeo/tests/dom-query-html.dart
@@ -50,37 +50,37 @@ void main() {
})
.test('getElementsByTagName(div)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.$dom_getElementsByTagName('div');
+ List<Element> elems = document.$dom_getElementsByTagName('div');
ret = elems.last().$dom_nodeType;
}
})
.test('getElementsByTagName(p)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.$dom_getElementsByTagName('p');
+ List<Element> elems = document.$dom_getElementsByTagName('p');
ret = elems.last().$dom_nodeType;
}
})
.test('getElementsByTagName(a)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.$dom_getElementsByTagName('a');
+ List<Element> elems = document.$dom_getElementsByTagName('a');
ret = elems.last().$dom_nodeType;
}
})
.test('getElementsByTagName(*)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.$dom_getElementsByTagName('*');
+ List<Element> elems = document.$dom_getElementsByTagName('*');
ret = elems.last().$dom_nodeType;
}
})
.test('getElementsByTagName (not in document)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.$dom_getElementsByTagName('strong');
+ List<Element> elems = document.$dom_getElementsByTagName('strong');
ret = elems.length == 0;
}
})
.test('getElementsByName', () {
for (int i = 0; i < num * 20; i++) {
- NodeList elems = document.$dom_getElementsByName('test$num');
+ List<Element> elems = document.$dom_getElementsByName('test$num');
ret = elems[elems.length-1].$dom_nodeType;
elems = document.$dom_getElementsByName('test$num');
ret = elems[elems.length-1].$dom_nodeType;
« no previous file with comments | « samples/third_party/dromaeo/tests/dom-query-dom.dart ('k') | samples/third_party/dromaeo/tests/dom-query-htmlidiomatic.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698