Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10805054: Fix broken paddings of the WebsiteSettingsPopopView. (Closed)

Created:
8 years, 5 months ago by markusheintz_
Modified:
8 years, 5 months ago
Reviewers:
battre
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix broken paddings of the WebsiteSettingsPopopView. BUG=113688 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147937

Patch Set 1 #

Patch Set 2 : Address comments (battre). #

Patch Set 3 : " #

Patch Set 4 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -39 lines) Patch
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 2 3 6 chunks +27 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
markusheintz_
Dominic could you please review this CL. It fixes the broken paddings I showed you.
8 years, 5 months ago (2012-07-23 12:23:09 UTC) #1
battre
could you upload a screenshot?
8 years, 5 months ago (2012-07-23 13:05:43 UTC) #2
markusheintz_
On 2012/07/23 12:23:09, markusheintz_ wrote: > Dominic could you please review this CL. It fixes ...
8 years, 5 months ago (2012-07-23 13:15:30 UTC) #3
markusheintz_
On 2012/07/23 13:15:30, markusheintz_ wrote: > On 2012/07/23 12:23:09, markusheintz_ wrote: > > Dominic could ...
8 years, 5 months ago (2012-07-23 15:04:59 UTC) #4
battre
lgtm
8 years, 5 months ago (2012-07-23 17:43:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10805054/9003
8 years, 5 months ago (2012-07-23 17:43:53 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 20:57:51 UTC) #7
Change committed as 147937

Powered by Google App Engine
This is Rietveld 408576698