Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 10805054: Fix broken paddings of the WebsiteSettingsPopopView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/website_settings/permission_selector_view.h" 5 #include "chrome/browser/ui/views/website_settings/permission_selector_view.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/ui/website_settings/website_settings_ui.h" 8 #include "chrome/browser/ui/website_settings/website_settings_ui.h"
9 #include "grit/generated_resources.h" 9 #include "grit/generated_resources.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
11 #include "ui/base/models/simple_menu_model.h" 11 #include "ui/base/models/simple_menu_model.h"
12 #include "ui/gfx/image/image.h" 12 #include "ui/gfx/image/image.h"
13 #include "ui/views/controls/button/menu_button.h" 13 #include "ui/views/controls/button/menu_button.h"
14 #include "ui/views/controls/image_view.h" 14 #include "ui/views/controls/image_view.h"
15 #include "ui/views/controls/label.h" 15 #include "ui/views/controls/label.h"
16 #include "ui/views/controls/menu/menu_model_adapter.h" 16 #include "ui/views/controls/menu/menu_model_adapter.h"
17 #include "ui/views/controls/menu/menu_runner.h" 17 #include "ui/views/controls/menu/menu_runner.h"
18 #include "ui/views/layout/grid_layout.h" 18 #include "ui/views/layout/grid_layout.h"
19 #include "ui/views/view.h" 19 #include "ui/views/view.h"
20 #include "ui/views/widget/widget.h" 20 #include "ui/views/widget/widget.h"
21 21
22 namespace { 22 namespace {
23 23
24 // Left icon margin. 24 // Left icon margin.
25 const int kPermissionIconMarginLeft = 6; 25 const int kPermissionIconMarginLeft = 6;
26 // The width of the column that contains the permissions icons. 26 // The width of the column that contains the permissions icons.
27 const int kPermissionIconColumnWidth = 20; 27 const int kPermissionIconColumnWidth = 20;
28 // Left margin of the label that displays the permission types.
29 const int kPermissionsRowLabelMarginLeft = 8;
30 28
31 // An array with |ContentSetting|s ordered by CommandID. The array is used to 29 // An array with |ContentSetting|s ordered by CommandID. The array is used to
32 // lookup a content setting for a given command id. 30 // lookup a content setting for a given command id.
33 const ContentSetting kSettingsForCommandIDs[] = { 31 const ContentSetting kSettingsForCommandIDs[] = {
34 CONTENT_SETTING_DEFAULT, // COMMAND_SET_TO_DEFAULT 32 CONTENT_SETTING_DEFAULT, // COMMAND_SET_TO_DEFAULT
35 CONTENT_SETTING_ALLOW, // COMMAND_SET_TO_ALLOW 33 CONTENT_SETTING_ALLOW, // COMMAND_SET_TO_ALLOW
36 CONTENT_SETTING_BLOCK, // COMMAND_SET_TO_BLOCK 34 CONTENT_SETTING_BLOCK, // COMMAND_SET_TO_BLOCK
37 }; 35 };
38 36
39 } // namespace 37 } // namespace
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 views::GridLayout::FIXED, 207 views::GridLayout::FIXED,
210 kPermissionIconColumnWidth, 208 kPermissionIconColumnWidth,
211 0); 209 0);
212 column_set->AddPaddingColumn(0, kPermissionIconMarginLeft); 210 column_set->AddPaddingColumn(0, kPermissionIconMarginLeft);
213 column_set->AddColumn(views::GridLayout::FILL, 211 column_set->AddColumn(views::GridLayout::FILL,
214 views::GridLayout::FILL, 212 views::GridLayout::FILL,
215 1, 213 1,
216 views::GridLayout::USE_PREF, 214 views::GridLayout::USE_PREF,
217 0, 215 0,
218 0); 216 0);
219 column_set->AddPaddingColumn(0, kPermissionsRowLabelMarginLeft);
220 column_set->AddColumn(views::GridLayout::FILL, 217 column_set->AddColumn(views::GridLayout::FILL,
221 views::GridLayout::FILL, 218 views::GridLayout::FILL,
222 1, 219 1,
223 views::GridLayout::USE_PREF, 220 views::GridLayout::USE_PREF,
224 0, 221 0,
225 0); 222 0);
226 223
227 layout->StartRow(1, column_set_id); 224 layout->StartRow(1, column_set_id);
228 // Create the permission icon. 225 // Create the permission icon.
229 icon_ = new views::ImageView(); 226 icon_ = new views::ImageView();
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 ContentSetting PermissionSelectorView::GetSelectedSetting() const { 281 ContentSetting PermissionSelectorView::GetSelectedSetting() const {
285 return menu_button_model_->current_setting(); 282 return menu_button_model_->current_setting();
286 } 283 }
287 284
288 ContentSettingsType PermissionSelectorView::GetPermissionType() const { 285 ContentSettingsType PermissionSelectorView::GetPermissionType() const {
289 return menu_button_model_->site_permission(); 286 return menu_button_model_->site_permission();
290 } 287 }
291 288
292 PermissionSelectorView::~PermissionSelectorView() { 289 PermissionSelectorView::~PermissionSelectorView() {
293 } 290 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698