Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10805051: Add RenderViewHost* to DidStartLoading and DidStopLoading in (Closed)

Created:
8 years, 5 months ago by tburkard
Modified:
8 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, gavinp+prer_chromium.org, tburkard+watch_chromium.org, jam, ajwong+watch_chromium.org, kkania, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, robertshield, mmenke
Visibility:
Public.

Description

Add RenderViewHost* to DidStartLoading and DidStopLoading in the interface of WebContensObserver. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147967

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -48 lines) Patch
M chrome/browser/automation/automation_tab_helper.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tburkard
8 years, 5 months ago (2012-07-21 01:10:03 UTC) #1
jochen (gone - plz use gerrit)
The plumbing in content/ looks correct. However, what's the reason for this change? You don't ...
8 years, 5 months ago (2012-07-23 15:05:27 UTC) #2
tburkard
Will make use of it in a separate change.
8 years, 5 months ago (2012-07-23 19:40:55 UTC) #3
jam
8 years, 5 months ago (2012-07-23 20:18:49 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698