Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

Issue 10805051: Add RenderViewHost* to DidStartLoading and DidStopLoading in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
===================================================================
--- chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc (revision 147723)
+++ chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc (working copy)
@@ -146,12 +146,12 @@
TEST_F(CaptivePortalTabHelperTest, HttpSuccess) {
SimulateSuccess(GURL(kHttpUrl));
- tab_helper().DidStopLoading();
+ tab_helper().DidStopLoading(NULL);
}
TEST_F(CaptivePortalTabHelperTest, HttpTimeout) {
SimulateTimeout(GURL(kHttpUrl));
- tab_helper().DidStopLoading();
+ tab_helper().DidStopLoading(NULL);
}
// Same as above, but simulates what happens when the Link Doctor is enabled,
@@ -168,12 +168,12 @@
EXPECT_CALL(mock_reloader(), OnLoadCommitted(net::OK)).Times(1);
tab_helper().DidCommitProvisionalLoadForFrame(
1, true, GURL(kErrorPageUrl), content::PAGE_TRANSITION_LINK, NULL);
- tab_helper().DidStopLoading();
+ tab_helper().DidStopLoading(NULL);
}
TEST_F(CaptivePortalTabHelperTest, HttpsSuccess) {
SimulateSuccess(GURL(kHttpsUrl));
- tab_helper().DidStopLoading();
+ tab_helper().DidStopLoading(NULL);
EXPECT_FALSE(tab_helper().IsLoginTab());
}
« no previous file with comments | « chrome/browser/captive_portal/captive_portal_tab_helper.cc ('k') | chrome/browser/extensions/extension_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698